Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 30 Nov 2018 15:46:24 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Yangtao Li <tiny.windzz@gmail.com>
Cc:     gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
        maco@android.com, joel@joelfernandes.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] binder: remove BINDER_DEBUG_ENTRY()
Message-ID: <20181201014624.7ukgr6e2c5msajzq@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Yangtao Li <tiny.windzz@gmail.com>, gregkh@linuxfoundation.org,
        arve@android.com, tkjos@android.com, maco@android.com,
        joel@joelfernandes.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20181201012630.4459-1-tiny.windzz@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="aenzoeexw3i3nwa4"
Content-Disposition: inline
In-Reply-To: <20181201012630.4459-1-tiny.windzz@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--aenzoeexw3i3nwa4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote:
> We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
> such a macro,so remove BINDER_DEBUG_ENTRY.
>=20
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>

Good catch.

Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>

On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote:
> We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
> such a macro,so remove BINDER_DEBUG_ENTRY.
>=20
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  drivers/android/binder.c | 48 ++++++++++++++--------------------------
>  1 file changed, 17 insertions(+), 31 deletions(-)
>=20
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index cb30a524d16d..5496b8e07234 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -94,22 +94,8 @@ static struct dentry *binder_debugfs_dir_entry_root;
>  static struct dentry *binder_debugfs_dir_entry_proc;
>  static atomic_t binder_last_id;
> =20
> -#define BINDER_DEBUG_ENTRY(name) \
> -static int binder_##name##_open(struct inode *inode, struct file *file) \
> -{ \
> -	return single_open(file, binder_##name##_show, inode->i_private); \
> -} \
> -\
> -static const struct file_operations binder_##name##_fops =3D { \
> -	.owner =3D THIS_MODULE, \
> -	.open =3D binder_##name##_open, \
> -	.read =3D seq_read, \
> -	.llseek =3D seq_lseek, \
> -	.release =3D single_release, \
> -}
> -
> -static int binder_proc_show(struct seq_file *m, void *unused);
> -BINDER_DEBUG_ENTRY(proc);
> +static int proc_show(struct seq_file *m, void *unused);
> +DEFINE_SHOW_ATTRIBUTE(proc);
> =20
>  /* This is only defined in include/asm-arm/sizes.h */
>  #ifndef SZ_1K
> @@ -4964,7 +4950,7 @@ static int binder_open(struct inode *nodp, struct f=
ile *filp)
>  		proc->debugfs_entry =3D debugfs_create_file(strbuf, 0444,
>  			binder_debugfs_dir_entry_proc,
>  			(void *)(unsigned long)proc->pid,
> -			&binder_proc_fops);
> +			&proc_fops);
>  	}
> =20
>  	return 0;
> @@ -5592,7 +5578,7 @@ static void print_binder_proc_stats(struct seq_file=
 *m,
>  }
> =20
> =20
> -static int binder_state_show(struct seq_file *m, void *unused)
> +static int state_show(struct seq_file *m, void *unused)
>  {
>  	struct binder_proc *proc;
>  	struct binder_node *node;
> @@ -5631,7 +5617,7 @@ static int binder_state_show(struct seq_file *m, vo=
id *unused)
>  	return 0;
>  }
> =20
> -static int binder_stats_show(struct seq_file *m, void *unused)
> +static int stats_show(struct seq_file *m, void *unused)
>  {
>  	struct binder_proc *proc;
> =20
> @@ -5647,7 +5633,7 @@ static int binder_stats_show(struct seq_file *m, vo=
id *unused)
>  	return 0;
>  }
> =20
> -static int binder_transactions_show(struct seq_file *m, void *unused)
> +static int transactions_show(struct seq_file *m, void *unused)
>  {
>  	struct binder_proc *proc;
> =20
> @@ -5660,7 +5646,7 @@ static int binder_transactions_show(struct seq_file=
 *m, void *unused)
>  	return 0;
>  }
> =20
> -static int binder_proc_show(struct seq_file *m, void *unused)
> +static int proc_show(struct seq_file *m, void *unused)
>  {
>  	struct binder_proc *itr;
>  	int pid =3D (unsigned long)m->private;
> @@ -5703,7 +5689,7 @@ static void print_binder_transaction_log_entry(stru=
ct seq_file *m,
>  			"\n" : " (incomplete)\n");
>  }
> =20
> -static int binder_transaction_log_show(struct seq_file *m, void *unused)
> +static int transaction_log_show(struct seq_file *m, void *unused)
>  {
>  	struct binder_transaction_log *log =3D m->private;
>  	unsigned int log_cur =3D atomic_read(&log->cur);
> @@ -5735,10 +5721,10 @@ static const struct file_operations binder_fops =
=3D {
>  	.release =3D binder_release,
>  };
> =20
> -BINDER_DEBUG_ENTRY(state);
> -BINDER_DEBUG_ENTRY(stats);
> -BINDER_DEBUG_ENTRY(transactions);
> -BINDER_DEBUG_ENTRY(transaction_log);
> +DEFINE_SHOW_ATTRIBUTE(state);
> +DEFINE_SHOW_ATTRIBUTE(stats);
> +DEFINE_SHOW_ATTRIBUTE(transactions);
> +DEFINE_SHOW_ATTRIBUTE(transaction_log);
> =20
>  static int __init init_binder_device(const char *name)
>  {
> @@ -5792,27 +5778,27 @@ static int __init binder_init(void)
>  				    0444,
>  				    binder_debugfs_dir_entry_root,
>  				    NULL,
> -				    &binder_state_fops);
> +				    &state_fops);
>  		debugfs_create_file("stats",
>  				    0444,
>  				    binder_debugfs_dir_entry_root,
>  				    NULL,
> -				    &binder_stats_fops);
> +				    &stats_fops);
>  		debugfs_create_file("transactions",
>  				    0444,
>  				    binder_debugfs_dir_entry_root,
>  				    NULL,
> -				    &binder_transactions_fops);
> +				    &transactions_fops);
>  		debugfs_create_file("transaction_log",
>  				    0444,
>  				    binder_debugfs_dir_entry_root,
>  				    &binder_transaction_log,
> -				    &binder_transaction_log_fops);
> +				    &transaction_log_fops);
>  		debugfs_create_file("failed_transaction_log",
>  				    0444,
>  				    binder_debugfs_dir_entry_root,
>  				    &binder_transaction_log_failed,
> -				    &binder_transaction_log_fops);
> +				    &transaction_log_fops);
>  	}
> =20
>  	/*
> --=20
> 2.17.0
>=20

--=20
Cheers,
Joey Pabalinas

--aenzoeexw3i3nwa4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwB5+8ACgkQ2rGdfm9D
tVLhphAAsBmrt1cSnwvaCThNuz/NLMwDiZ8l+Rez5KydpAkZ3nVfdNZBu4gFiGeI
5HFZM7wpiKJToCqXtfEfCSBTxt9g7vhEfwItr49vpV74SFxcfVEET32KFVPDR1Qj
2wJ/M4Zou7CmvspZ61h/MA79cqrEU9CyYWzGu3wbjhZg0xJhATR2xIAMCVWpCPkS
tTmd3/8P19yBN5c60YdIRriT5Mg5nE9eNdTIi8GyBVZj8iWHJBjqRXPAaEuVC18f
Km54+QZzsN0OvoM7NO1PQ18CQvvwqF+pkqJxoqpc6IK9G4DCb22Bid34VFtCL8PZ
62CYBVmqhZ7laLADPE690Onlj8j4NrWQkAgLkaPpiGEEqRSZm6AnAZ8eo8W12wN9
2QsBU0WF/g4+YbI/RRxq2/J9Z5N6xn8RUoBGdoRMSBJc/bUO4ukoB9ogAmp2jKKl
FFQLvUiDSgptszI1hpaBmLZsWmkMs/hqANkDRxKC8/42Isgh8KLZUgtUWu3a0R3s
Uyxoi6TC8FGcV8/vUxNIC5Ift1IKrxtBS7la8yt6wRKpsJDAx1efTsjQrCwm6/v4
Zwh0qU+UVB9KyTs/tLsRu/5f6QrvSZK3uvIqIgqtKePDb/U9l477rPYkLifk695b
4c0tvUGMPjczabD19K5Hoz/DtI2e4KoP/TcZoQ6N4AnUc24UOmw=
=NMOf
-----END PGP SIGNATURE-----

--aenzoeexw3i3nwa4--