Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4491103imu; Fri, 30 Nov 2018 19:03:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/XnJp7RWBOvmUfK6n2sbgLdYgc0Xa8NVZyUNKI0ZKIehkWANWh6ml8z+2Fywnp/WJHB9sPB X-Received: by 2002:a17:902:4623:: with SMTP id o32-v6mr7901843pld.187.1543633415154; Fri, 30 Nov 2018 19:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543633415; cv=none; d=google.com; s=arc-20160816; b=eec6UZw2G4z5kdyz8fiq1NafY21QTr8Ca0SBlLBTQVHk839CD4we8/mJMjMBc1XJvj LEdGAjUb1gIOieJjBWReYshPBsLM0gHY4eQXMzulbkeZNewolJ7z4rXO7lqt7ERqPc93 v6y/oVd5ycNmXKTHYvaf82kR+j3Jev0LvrXnR7PpQ0qhRRBLuYjVRdWqBjnsq1QyGxwr OeV/N6MIGauUi9KJxSEwZK/ETRJqLvak6Bx+TozuVxNLYS4E7MEkft6BN0d98wmA+Wb/ u72JpGTDJ4OZF6IFdham2zoJK1tJnZaQpDmg8STfCo7EYeFb3ekQV3dhrWV0KhX2zaFD 9LeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Y8FFqlo+hs5jsQ9Y7l6rpCXKk9O09swMpG6+1RK/fCg=; b=t4MPs1XggkZDS/IrAdNlAkpUpy3ElcmqK6n42COQ/y/AuDKbAQDaGt6H4iyA9jHxTv GfGTJTgLO0V79IRXj7/C79lYU+/hrFHuE5d6eC8xAmtQN/HsiDQItcifM5Uk5slpYqEs 7T7LfXUR4e9IT7RV0EM+37y1+7Af4RRfMts/4WzN7UvBMAfPYnev4XJRA/Q8Pvt/ccGh bjSLaGrr2ZW+slGNDkMYUbCLjoClgvr3FODUl2lKwU3Fr0FLvhlZcdKQh5rBAOnsjSCz NycZujJrJXayKxXpsUn0ThEXgyMCLrG9e6jmdtb5jHVwFHle5ejQAuljCKlAejcW9lMO BaWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si7005008pgl.109.2018.11.30.19.03.20; Fri, 30 Nov 2018 19:03:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbeLAONq (ORCPT + 99 others); Sat, 1 Dec 2018 09:13:46 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:37211 "EHLO mail-pf1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbeLAONq (ORCPT ); Sat, 1 Dec 2018 09:13:46 -0500 Received: by mail-pf1-f176.google.com with SMTP id y126so3715651pfb.4; Fri, 30 Nov 2018 19:02:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y8FFqlo+hs5jsQ9Y7l6rpCXKk9O09swMpG6+1RK/fCg=; b=TI+EkpGpCGpNq2mDJCgVTtVxLx2Q+7uaUr0yU0wd+rLfF8rxNnuIQDxdybPp3cQWzA ub0MvotVLTI4/OS3fxlmJjPXibXTlo5n5XvELptxJUXpmmBPimUcMq7YahuNAmejJtqQ hfH5jmXMsHukvwaj/Vho5XhubweDoJdtLUpwKYnQrMBTcH3YxLtWnskOpp8iHCwtRWy4 jh9lNkVj/MAPGLueLuiSrhhOAuArfiwG2totPpG0wmeFgFNz7x7lI0Ma521LslO9CpzR fXvwPy7f4ChgprVLwtR4T69hV0WxLzi1BvLDyXMu9XjIuoMkPUvFsHsHkX+BdKaxxEYj AzkQ== X-Gm-Message-State: AA+aEWbGrqlJekMZCsFrqpSsHYlrytItG0nj02C3eIe7iRfnpwVu8fUL NANQL+4ZaXVP1M+JrGpnU+4= X-Received: by 2002:a62:ea09:: with SMTP id t9mr3076526pfh.228.1543633339449; Fri, 30 Nov 2018 19:02:19 -0800 (PST) Received: from garbanzo.do-not-panic.com (c-73-71-40-85.hsd1.ca.comcast.net. [73.71.40.85]) by smtp.gmail.com with ESMTPSA id n68sm10221567pfb.62.2018.11.30.19.02.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 19:02:18 -0800 (PST) Received: by garbanzo.do-not-panic.com (sSMTP sendmail emulation); Fri, 30 Nov 2018 19:02:15 -0800 Date: Fri, 30 Nov 2018 19:02:15 -0800 From: Luis Chamberlain To: Brendan Higgins Cc: gregkh@linuxfoundation.org, keescook@google.com, shuah@kernel.org, joel@jms.id.au, mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, julia.lawall@lip6.fr, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, robh@kernel.org, dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com, frowand.list@gmail.com, knut.omang@oracle.com, Petr Mladek , alexander.h.duyck@linux.intel.com Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core Message-ID: <20181201030215.GJ28501@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181128193636.254378-2-brendanhiggins@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > +int kunit_run_tests(struct kunit_module *module) > +{ > + bool all_passed = true, success; > + struct kunit_case *test_case; > + struct kunit test; > + int ret; > + > + ret = kunit_init_test(&test, module->name); > + if (ret) > + return ret; > + > + for (test_case = module->test_cases; test_case->run_case; test_case++) { > + success = kunit_run_case(&test, module, test_case); We are running test cases serially, why not address testing asynchronously, this way tests can also be paralellized when possible, therefore decreasing test time even further. Would that mess up the printing/log stuff somehow? Luis