Date: Thu, 15 Jan 2004 18:54:00 -0800
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: joe.korty@ccur.com, paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: seperator error in __mask_snprintf_len
Message-Id: <20040115185400.31c9d670.pj@sgi.com>
In-Reply-To: <20040115170624.2851e19a.akpm@osdl.org>
References: <20040107165607.GA11483@rudolph.ccur.com>
	<20040107113207.3aab64f5.akpm@osdl.org>
	<20040108051111.4ae36b58.pj@sgi.com>
	<16381.57040.576175.977969@cargo.ozlabs.ibm.com>
	<20040108225929.GA24089@tsunami.ccur.com>
	<16381.61618.275775.487768@cargo.ozlabs.ibm.com>
	<20040114150331.02220d4d.pj@sgi.com>
	<20040115002703.GA20971@tsunami.ccur.com>
	<20040114204009.3dc4c225.pj@sgi.com>
	<20040115081533.63c61d7f.akpm@osdl.org>
	<20040115145357.1033d65a.pj@sgi.com>
	<20040115170624.2851e19a.akpm@osdl.org>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 999
Lines: 32


Thanks for the feedback, Andrew.

Two points you made that I now agree with:

 * Better that this code uses existing arch-dependent bitops,
   than that it have code pretending to be generic hiding
   additional arch specific dependencies.

 * Having just realized that the other existing include/bitmap.h
   calls take a count of bits, not bytes, I now agree with you
   and Joe that it should be bit counts.


> You can never provide too many comments!

Good - I'm on solid ground there ;)


> Anyway, please wake me up again when you and Joe have finished.

ok

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/