Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 1 Dec 2018 11:32:16 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Wen Yang <wen.yang99@zte.com.cn>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] sched/fair: Fix assignment of boolean variables
Message-ID: <20181201213216.wmikdw3emxhc7m5r@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Wen Yang <wen.yang99@zte.com.cn>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn
References: <20181201090936.10175-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3qy7gq5q4ryywuu6"
Content-Disposition: inline
In-Reply-To: <20181201090936.10175-1-wen.yang99@zte.com.cn>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--3qy7gq5q4ryywuu6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 01, 2018 at 05:09:36PM +0800, Wen Yang wrote:
> Fix the following warnings reported by coccinelle:
> kernel//sched/fair.c:7958:3-12: WARNING: Assignment of bool to 0/1
>=20
> This also makes the code more readable.
>=20
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: linux-kernel@vger.kernel.org

Ack, earlier assignments in the function like:

	if (nr_running > 1)
		*overload =3D true;

use `=3D true`, so this change keeps things consistent.

Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>

> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index a2e8160968cb..f19aa66f9b15 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7955,7 +7955,7 @@ static inline void update_sg_lb_stats(struct lb_env=
 *env,
>  		if (env->sd->flags & SD_ASYM_CPUCAPACITY &&
>  		    sgs->group_misfit_task_load < rq->misfit_task_load) {
>  			sgs->group_misfit_task_load =3D rq->misfit_task_load;
> -			*overload =3D 1;
> +			*overload =3D true;
>  		}
>  	}
> =20
> --=20
> 2.19.1
>=20

--=20
Cheers,
Joey Pabalinas

--3qy7gq5q4ryywuu6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwC/d8ACgkQ2rGdfm9D
tVLsDxAAomwGuyDsqVM69ubKTE2jhrOmh4g4B7O3/bSWYJqMd2is9S0HvzQL2Q8i
W5yl2bvtoCoWBYWdsBOofJMbj6it/WIZHbS8z4CtuWAVQJOQ/27tWwZbFjBKX/yo
7YR+7klVlFp0PyCtSurpEFBJCCPYIzTQsddi07eFlJ+EoB/NIPPSR20bwTfmWzTe
HQVO+5I0T5F3Kd6Qkp94X3tCgZ3c14RyfznTlHd0Pha3sfgU70hraGf6olgbzx4W
7kBVqXgVG7C5oPBvnKlDOsO6wmk6KbymaKy9uyny4lPTdi2uyItzFoxZMVUCez4w
opKn176HE+Le9fDbFe7EKqW4JLYFt8hmt9EMDUHOmUy9+OsUMFNbeQWVPLAw6Fct
wtxS8GeiuCPk5C3z+3UikSAjNzj1f0RRzjH9YdMBTKKnGCATxxYTFrib5iTIRTIt
2aqtzfmJg/qOlUW3//cFF6XmJ7oeIsass9h4bRcsbDL8L4ZoL2HMei1o/444CcRb
DhOP6V0SWw+drNhjV03cNq/7lG5RynG86SKekNxrTbwuXe1io5XSJ7p6D1TetXGV
OW4AfphuGHYe5xITsvEYSncg6GOD25gLBlD94JvlRyaKISrvz/5/4Drd2OW7m0BV
OZAti70SbXECFw1ehUPjyWkNgGNSr1WXk9cn4p3K1TEAhuWdKpo=
=3cdh
-----END PGP SIGNATURE-----

--3qy7gq5q4ryywuu6--