Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 1 Dec 2018 21:33:38 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()
Message-ID: <20181202073338.aqkrezckv3mbqfj4@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Alexey Dobriyan <adobriyan@gmail.com>, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20181124093530.GE10969@avx2>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ng2csp2vkutxwbxb"
Content-Disposition: inline
In-Reply-To: <20181124093530.GE10969@avx2>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ng2csp2vkutxwbxb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote:
> -static inline asmlinkage void dump_stack(void)
> +static inline void dump_stack(void)

Why is it "silly"? An explanation in the commit message would be useful.

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>=20
>  include/linux/printk.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *l=
og_lvl)
>  {
>  }
> =20
> -static inline asmlinkage void dump_stack(void)
> +static inline void dump_stack(void)
>  {
>  }
> =20

--=20
Cheers,
Joey Pabalinas

--ng2csp2vkutxwbxb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwDitEACgkQ2rGdfm9D
tVLYEhAAqYIGJrc0WtVrgcSfh4NVtFXrzBNmVLqdwZSgdu1oCBuoexibTl3SBrls
d7xWynvA/IERBG+q2s8yaRURpii9bxixZUCc2cQUe9GXRxfjXAwR77gU1DXCuRdZ
fWzCT1XKxDulemrqhSK6GFz1doT84V/D7xP4qTZCsDYdxCWNlwMcQIST37I5AHBY
9n37sCjrNhvEcZC+bO0MtX7qcVNrFNsY/Y/VJWeb5Dc347evmUuXuCjR4VS+syY8
6KyKXfGLJW7k06Bg3stI+kq2hNzPl8fbnKNKbU5rev6UCqN++2FX5GFifQqxRpKq
+wk/sGvzKhgwc3ulrQTDL7/A56P9rU7FG2dpOlbc98GKbqWO0cIBEoRC9L5D3YuI
Nqf/AfYgeis+QH3Mw+jyLA4118Ms2z5nIKHrgsL3TTKaaVQRurPp9clL2j1LsvFl
T0NGVWniwfOUkvlndP/9G4/wqJhanmhy0R1ZI5AIAHyzwG+0BfLPHfOAkLaLkz25
1DhAZ/wj2Vvh80N1ToB9I5d8Jz+0v5xglQHy+Sen+5ynMu6ah3DM7iSXxIFH603o
DdcJx/EnGF84HFz5oAM6Afl7KyVxv6ZgHXqu9HXyRISQ/xCmi4iLfcs3ZBtJ4Dwn
wNEHJNu2dC4umrd5c+pGKNc9N3j6C0/ZsrCGDW+Lb9ZPfsSXcOQ=
=rzch
-----END PGP SIGNATURE-----

--ng2csp2vkutxwbxb--