Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181202073202.10587-1-tiny.windzz@gmail.com> <20181202091543.73c74aea@bbrezillon>
In-Reply-To: <20181202091543.73c74aea@bbrezillon>
From:   Frank Lee <tiny.windzz@gmail.com>
Date:   Sun, 2 Dec 2018 16:35:20 +0800
Message-ID: <CAEExFWtRoC2dQd_6B5d1c1tt-stdSa4jafBNTsUWJxrZkczfkw@mail.gmail.com>
Subject: Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()
To:     boris.brezillon@bootlin.com
Cc:     robert.jarzmik@free.fr, David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        =?UTF-8?B?TWFyZWsgVmHFoXV0?= <marek.vasut@gmail.com>,
        richard@nod.at, miquel.raynal@bootlin.com,
        Kees Cook <keescook@chromium.org>,
        Shreeya Patel <shreeya.patel23498@gmail.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon
<boris.brezillon@bootlin.com> wrote:
>
> Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change
> you do. I think you should change the subject line:
>
> "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it"
>
> This way it covers all of your changes.
>
> On Sun,  2 Dec 2018 02:32:02 -0500
> Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
>
>                                             ^ missing space
>
> > such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE
>
>                ^ here as well
>
> > to simplify some code.
>
> If you go for the new subject line, you'll have to change this commit
> message.
How about the newer?

MBR,
Yangtao