Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5690833imu; Sun, 2 Dec 2018 01:03:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/X8KRs3ETGSHU19ZYiCy/8ZVmbCbO4ZMHr0cb42INejGHHDUFWgY5V4fxVByyB2VgfieKeO X-Received: by 2002:a17:902:29a7:: with SMTP id h36mr11882191plb.244.1543741434040; Sun, 02 Dec 2018 01:03:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543741434; cv=none; d=google.com; s=arc-20160816; b=00bEBZNtKhHTW2BDxmrdN/8y7r6P5ah0oMxE4s+c4ZWzhAJEnTYy97pQDhkkI/g0k2 /n47Z0QrZ5pCehQVv5Ey2nTfFkZoOkdkU3ghyggJ5hn390rZjRn4eiTbrEjrLvEOLcxD D31j0R1MXU7Of3xnSFJZyMMwe2DjA6LstRqSNva4IhFVn5fLUvnV1Yq/XCP8MuoSe7n9 leHGPSVBn1Fz+fq4wM1iipvPT5/54MT4pG3cMEwe7P7iOkCtJGKgE5Oo/iePIuwY0nZm 8DKIvNJPXHdrZjs382HOPPEpTDjwVu4Fh0cwcCkIQTFMpBJUCqLYqDfQvivNL5V0LWfs oD1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=E4frXRxd1NVD6OhvDRr9jQEEiRFDLLZYVaWl34FipDg=; b=wLO25C7UtiRSBkiDOMx5EnjlOLRoXfglxcfH+s1JEoF1F87pwdKTbmz0c7g9JQ9KJ4 +fF7anUa09TYEMgt4JmIM3tGKzbp3mz/lVsZMLB1UpNxJupeEHZHVzzzutXU1HCupfgD oGllOZGpl+wzdwSpPI/QAsV3kQIy52U3utiVt7f1b/MpIsPmBNMa7VxkuArIRrqthM5V 8mnK28L3LNCK+LpAXxfaPcNSFWvWU4Qac3PXpgMrDRGnmDiefuzVj6bAQM5mEVlppzto NzNRTw4AW3ZeY1j6yJA9p7F04fv/RC3zgrV2bUzTjsn+haOJlID8TigAY2pSKwIs4J9J f7zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MYGS9b9M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3si10128215plt.394.2018.12.02.01.03.39; Sun, 02 Dec 2018 01:03:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MYGS9b9M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725806AbeLBJDH (ORCPT + 99 others); Sun, 2 Dec 2018 04:03:07 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46359 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbeLBJDG (ORCPT ); Sun, 2 Dec 2018 04:03:06 -0500 Received: by mail-wr1-f65.google.com with SMTP id l9so9108144wrt.13 for ; Sun, 02 Dec 2018 01:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=E4frXRxd1NVD6OhvDRr9jQEEiRFDLLZYVaWl34FipDg=; b=MYGS9b9M/iqXORXtl00bQdDzq/mAtWoXgJsyW4UFhP8a2fVJgPdvvmtwpWx6U/pd1+ TsZgoXy7vukaRKT0dJuqkGZCjCJgVrJCcWaN3lwZI5dPZ/YAT3FjyrZgbqdNfpyI2VBc 2HXsaD/byglYl4KoDWEgqevVxboxquIVDRrml0pD4JU8gErOil1bTVzm8DV9Y+KCOYon AJgUd4SWx2o/R71zX+YkZK91zvV9dW+zxh+FQpdabEXHcaY8Pv0Tdgb6TK8GOkkKy+wY cQVsXVxCDH9eew+b7dfBmBy/lyFs7ayTIT+tt67mhOUt+kactZbWdc9g1bmDlDkiHuLV 3nLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=E4frXRxd1NVD6OhvDRr9jQEEiRFDLLZYVaWl34FipDg=; b=XtNYM8ZYk5HqQakSZb2MKYEJgdkvsSsgIvpNt0JJICdyT7ebM02VuBDaUuD4w+UBhj r2m8z+aQTfKZ6Eot4HN6LuvMhEABDjMMvHXRwCGRURUP9f1pCLSsK8qRrXXFIDmeMSj6 fvgNJL+0bkS2JrbTi3eSi1SgSXYadquJQoDlBHs6IhcRnordGgM1MzlSKfKlx1cdcaR0 yj0VJqlXTKitzGGyOHt18FkEZptYl8Nw6KKlb/+NOIIZ3ZAi4BR/aBDADJ6t6q1C4H02 83w0q1BOcH2K68kO7ORp5a9LiHkm6aKCNH0Wuh4dTYLe5a7soCaO/JtMy+x1JH5DpbkG ZZKA== X-Gm-Message-State: AA+aEWbjn5OtC7FcOH2K9YlueC1HOngBYe7qnE+NJaONX1u3YY3ahcxP 1pmLFBn1xrhZLxlmDm40pg== X-Received: by 2002:adf:f8d2:: with SMTP id f18mr5821955wrq.265.1543741377927; Sun, 02 Dec 2018 01:02:57 -0800 (PST) Received: from avx2 (nat-minsk-pool-46-53-201-92.telecom.by. [46.53.201.92]) by smtp.gmail.com with ESMTPSA id d2sm8582348wrs.97.2018.12.02.01.02.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Dec 2018 01:02:56 -0800 (PST) Date: Sun, 2 Dec 2018 12:02:54 +0300 From: Alexey Dobriyan To: Joey Pabalinas , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack() Message-ID: <20181202090254.GA3896@avx2> References: <20181124093530.GE10969@avx2> <20181202073338.aqkrezckv3mbqfj4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181202073338.aqkrezckv3mbqfj4@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 01, 2018 at 09:33:38PM -1000, Joey Pabalinas wrote: > On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote: > > -static inline asmlinkage void dump_stack(void) > > +static inline void dump_stack(void) > > Why is it "silly"? An explanation in the commit message would be useful. Empty function will be inlined so asmlinkage doesn't do anything.