Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pawel Laszczak <pawell@cadence.com>
To:     PETER CHEN <peter.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alan Douglas <adouglas@cadence.com>,
        "jbergsagel@ti.com" <jbergsagel@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
        Suresh Punnoose <sureshp@cadence.com>,
        Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [RFC PATCH v2 02/15] usb:cdns3: Device side header file.
Thread-Topic: [RFC PATCH v2 02/15] usb:cdns3: Device side header file.
Thread-Index: AQHUfycJzsVSHKUPpEauszYsGMPBFaVn8v8AgAPP8mA=
Date:   Sun, 2 Dec 2018 19:27:28 +0000
Message-ID: <BYAPR07MB4709E47639F2DA3339D99147DDAD0@BYAPR07MB4709.namprd07.prod.outlook.com>
References: <1542535751-16079-1-git-send-email-pawell@cadence.com>
 <1542535751-16079-3-git-send-email-pawell@cadence.com>
 <VI1PR04MB5327F686BE6E9F5D85380BA98BD30@VI1PR04MB5327.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB5327F686BE6E9F5D85380BA98BD30@VI1PR04MB5327.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f2d09a9-df31-4fde-e416-08d6588c3250
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2018 19:27:28.1090
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5415
X-Proofpoint-SPF-Result: pass
X-Proofpoint-SPF-Record: v=spf1 include:_spf.salesforce.com include:mktomail.com
 include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com
 include:auth.msgapp.com include:spf.mandrillapp.com ~all
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-02_11:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1812020187
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter
>> +
>> +/*
>> + * USBSS-DEV register interface.
>> + * This corresponds to the USBSS Device Controller Interface  */
>> +/**
>> + * struct xhci_cap_regs - xHCI Host Controller Capability Registers.
>
>struct cdns3_usb_regs - device controller registers

thanks, =20
I had this from beginning. I don't know why. =20
I=20
>
>> +struct cdns3_device;
>> +
>> +struct cdns3_endpoint {
>> +	struct usb_ep		endpoint;
>> +	struct list_head	request_list;
>> +	struct list_head	ep_match_pending_list;
>> +
>> +	struct cdns3_trb	*trb_pool;
>> +	dma_addr_t		trb_pool_dma;
>> +
>> +	struct cdns3_device	*cdns3_dev;
>> +	char			name[20];
>> +
>> +#define EP_ENABLED		BIT(0)
>> +#define EP_STALL		BIT(1)
>> +#define EP_WEDGE		BIT(2)
>> +#define EP_TRANSFER_STARTED	BIT(3)
>> +#define EP_UPDATE_EP_TRBADDR	BIT(4)
>> +#define EP_PENDING_REQUEST	BIT(5)
>> +#define EP_USED			BIT(5)
>> +	u32			flags;
>> +
>> +	void			*aligned_buff;
>> +	dma_addr_t		aligned_dma_addr;
>> +	u8			dir;
>> +	u8			num;
>> +	u8			type;
>> +
>> +	int			free_trbs;
>> +	u8			pcs;
>> +	u8			ccs;
>> +	int			enqueue;
>> +	int			dequeue;
>> +};
>> +
>
>Would you please add kernel doc for above structure?

Done.
>
>> +struct cdns3_request {
>> +	struct usb_request request;
>> +	struct cdns3_endpoint *priv_ep;
>> +	struct cdns3_trb *trb;
>> +	int start_trb;
>> +	int end_trb;
>> +	int on_ring:1;
>> +};
>> +
>> +#define to_cdns3_request(r) (container_of(r, struct cdns3_request,
>> +request))
>> +
>> +struct cdns3_device {
>> +	struct device			dev;
>> +	struct cdns3_usb_regs		__iomem *regs;
>> +
>> +	struct usb_gadget		gadget;
>> +	struct usb_gadget_driver	*gadget_driver;
>> +
>> +	struct usb_ctrlrequest		*setup;
>> +	dma_addr_t			setup_dma;
>> +	dma_addr_t			trb_ep0_dma;
>> +	struct cdns3_trb		*trb_ep0;
>> +	void				*zlp_buf;
>> +
>> +	struct cdns3_endpoint		*eps[USB_SS_ENDPOINTS_MAX_COUNT];
>> +	int				ep_nums;
>> +	/*
>> +	 * field used for improving performance. It holds the last
>> +	 * selected endpoint number
>> +	 */
>> +	u32				selected_ep;
>> +	struct usb_request		*ep0_request;
>> +	int				ep0_data_dir;
>> +	int				hw_configured_flag;
>> +	int				wake_up_flag;
>> +	u16				isoch_delay;
>> +	/* generic spin-lock for drivers */
>> +	spinlock_t			lock;
>> +
>> +	unsigned			is_connected:1;
>> +	unsigned			in_standby_mode:1;
>> +	unsigned			status_completion_no_call:1;
>> +	unsigned			u1_allowed:1;
>> +	unsigned			u2_allowed:1;
>> +
>> +	u32				usb_ien;
>> +	u32				ep_ien;
>> +	int				setup_pending;
>> +	struct device			*sysdev;
>> +	/* The device mode is enabled */
>> +	int				start_gadget;
>> +	struct list_head		ep_match_list;
>> +	/* KB */
>> +	int				onchip_mem_allocated_size;
>> +	/* Memory is allocated for OUT */
>> +	int				out_mem_is_allocated:1;
>> +	struct work_struct		pending_status_wq;
>> +	struct usb_request		*pending_status_request;
>> +};
>> +

Cheers
Pawel