Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6240107imu; Sun, 2 Dec 2018 13:15:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/UrOiu+Np7HmfQd39yg8Hs+hIDcWvqpvoVDWvUWfqYKsUowrgOpy0+2JQYwvytJzhmOQx3k X-Received: by 2002:a63:4926:: with SMTP id w38mr10816829pga.353.1543785329518; Sun, 02 Dec 2018 13:15:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785329; cv=none; d=google.com; s=arc-20160816; b=SRdWjXPGLv+ogPDyiQdxK/kIoydonYDah+UlU+T4f5NHC4DIXTebmpS0dMjb0V1PaE v6iXrANHtn3Xq980oFRaDxc57oiHDO3s2wcjWHx9DnmiFeyiKG4vMAOnWudJgHJLpFg4 gHzgxLIpaC3cgGZrIKvUXFbPX+4BhmWCll9uDj3PMTAVUM7DHxFj3NDNDqj+Shh+Dh21 x2PRgM5r6Tu9fCapbg8G6xEGSYpdgoV4QrSKv96pJDFyOYulxPUvoCYUASphmTpVJtHu sfr37vB7XSyst35+H+C+0THhHP3++MZftljViwx6cSP1etezWayXypHQKyCSgLmriVsM f1Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=3+tGOkjHi1yQl7NVxm7H+SL/tp6+Qr/OiO1XRc7T38M=; b=LTtHjECPyN7CHWjd3vwMjwkWZgPo/jj3/assFM9aH+rqSDF23u+/MjpYZrE5djFbbp VZMzLbOJFKAPONhFSaRHypBLRWTNbdBqMJ+mov4aG6TyQGLqcB7ezGJO6DJoqtaVjlxw EKZUEQTQLPOTTu1jnx7ELbKXQcgFIR81XTGg+wvl0Xsh+aMpYTaSu4COb87R4GPbxsup 55ePJmPJe1OnVFfKB5h3WvngWEQ5/t7WsfrUt2JTF+BRhRdL00mkk9yBdvTIRsLZg0FY wxTid+LeFzObdQkhO+wSEsY2lpbpvKowgYgxTH1+Cw8Ev0kWR797DlqrgcKYkbiCpfjr v6Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si10014583pgv.456.2018.12.02.13.15.14; Sun, 02 Dec 2018 13:15:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725808AbeLBVOj (ORCPT + 99 others); Sun, 2 Dec 2018 16:14:39 -0500 Received: from www17.your-server.de ([213.133.104.17]:57316 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbeLBVOi (ORCPT ); Sun, 2 Dec 2018 16:14:38 -0500 X-Greylist: delayed 1159 seconds by postgrey-1.27 at vger.kernel.org; Sun, 02 Dec 2018 16:14:38 EST Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYlq-00016L-FZ; Sun, 02 Dec 2018 21:55:18 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYlq-0002jz-A8; Sun, 02 Dec 2018 21:55:18 +0100 Subject: [PATCH] scsi: csiostor: NULL check before some freeing functions is not needed. From: Thomas Meyer To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930051-584546236-8-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 8 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c --- a/drivers/scsi/csiostor/csio_init.c +++ b/drivers/scsi/csiostor/csio_init.c @@ -157,8 +157,7 @@ csio_dfs_create(struct csio_hw *hw) static int csio_dfs_destroy(struct csio_hw *hw) { - if (hw->debugfs_root) - debugfs_remove_recursive(hw->debugfs_root); + debugfs_remove_recursive(hw->debugfs_root); return 0; }