Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6240374imu; Sun, 2 Dec 2018 13:15:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/XSVolRY+jr1xy6Cno1PhySMlMZ2bZ6u4/gCQ0T7fGoDbJb3GHtyLqJU9b2pQC0KJT23hvA X-Received: by 2002:a17:902:b943:: with SMTP id h3mr13731987pls.12.1543785349501; Sun, 02 Dec 2018 13:15:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785349; cv=none; d=google.com; s=arc-20160816; b=HVJTNyWhlXoPilNwM0vZn9EjJXLhE4UxNKhmKRalPIQZ2fbdn6vmrFNgoQ4SItBhbJ spUpurEUn3Nf/Hqdy4c10K/zcoez1AIhF8Ftn8g704KOqgFgm1Ny90hz7UVcrjS0tYma 87m1rVVs7p1IIROMdszkroonSBu5WmwrVywQyb0V11w8AeqgHTwmDbzd2Bjhw5gQIADA zHLP2Jb+Gb57Rna+4uBXbOqqmMlmxe3I700dU84YWwO8yVBfhCpXR7jYmK56Z7gIOJJG nl0BHQSe6tpA9AtJNNh9Nk7BV+1+v35lAVGqACPmVvpV+FvrJxqg1OhQeiTzx9L6ZWMV dAKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=bW5HdRb7x1Ug6fLE78gF94dbsgyEvy1kUurBw15z3CQ=; b=v1Sey88SfbPyVrwXwhU/ctj2R9xbQDxdwczBfvNaM1rL34DhdI5o7Bh6aVDV99/zGQ CMvFGUGIEAKjjx1/Y3PiAQjyeSf49akojJ/gQpmz7iPLz9oxmMohJQVXTs/m6Ivhia1m C1viull4jHV12/bvzZWoFbxSOhKqAN9IvN828rfpHuGuZAYN8hWy0d78yDkwHBcqCbll /LRy2fhLioZf1QE6MWQEp5+ntMTrwTzN9q5+JZ5OlOjDOaQdvfa2qwNsy5Gf8m4lRy6h KlcZFbQy3iN/vH0QLQuNtRm0YVq2iDifvBzrPqkrakb6dM8NIvr8T3HmHGo+fqyxhPR/ CTCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 189si12013769pfd.142.2018.12.02.13.15.35; Sun, 02 Dec 2018 13:15:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725860AbeLBVOt (ORCPT + 99 others); Sun, 2 Dec 2018 16:14:49 -0500 Received: from www17.your-server.de ([213.133.104.17]:57366 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbeLBVOt (ORCPT ); Sun, 2 Dec 2018 16:14:49 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYlu-00017E-AS; Sun, 02 Dec 2018 21:55:22 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYlu-0002zd-4n; Sun, 02 Dec 2018 21:55:22 +0100 Subject: [PATCH] scsi: NULL check before some freeing functions is not needed. From: Thomas Meyer To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930051-1215258621-7-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 7 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -584,8 +584,7 @@ static void asd_destroy_ha_caches(struct if (asd_ha->hw_prof.scb_ext) asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext); - if (asd_ha->hw_prof.ddb_bitmap) - kfree(asd_ha->hw_prof.ddb_bitmap); + kfree(asd_ha->hw_prof.ddb_bitmap); asd_ha->hw_prof.ddb_bitmap = NULL; for (i = 0; i < ASD_MAX_PHYS; i++) { @@ -660,12 +659,10 @@ Err: static void asd_destroy_global_caches(void) { - if (asd_dma_token_cache) - kmem_cache_destroy(asd_dma_token_cache); + kmem_cache_destroy(asd_dma_token_cache); asd_dma_token_cache = NULL; - if (asd_ascb_cache) - kmem_cache_destroy(asd_ascb_cache); + kmem_cache_destroy(asd_ascb_cache); asd_ascb_cache = NULL; }