Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6240549imu; Sun, 2 Dec 2018 13:16:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/V+1g/2DaCvFHTYTR2wqDeTVA2C+hx3OK0N1mEYpUi3zVrtDgjz9jFwkqAWr67/3w9ov1iw X-Received: by 2002:a62:56c7:: with SMTP id h68mr14116451pfj.134.1543785362047; Sun, 02 Dec 2018 13:16:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785362; cv=none; d=google.com; s=arc-20160816; b=OJEtp4rCMKyF9ShFzKPKhaUepF689TKpMZv/iyDZWUksmIpr9b4QfW+06iVtp6ZMYM 7g9Jy2OYA9aqPN68CQF4Kp6hDCDv0GgVd1Fmz/47N1bPiy7FVR13/54aCnvaRSfaKESL uwiPROhOQcD0jlI72MHx9fw7sKDqc4BdGMmzxmxjreeA3dkYO1RNJ4UnOFsbDQUlvnoy +Rd0I0aRk0l2NFd6r6Lu+BVaITvx4Ztvid15XLhcYGItA9zSXM8PVhYMoIXGAvnTyaCy 8nx5keGyhD9k8RFNw16rNVIg/NA/3F/zWU/3z6XyUvciOCPpiRxz5chjJ9QOBjW7pt4W wlvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=0u54ShadDmfdMBVzKqkuIxMRsIjE4LVB0vwQV0BEakg=; b=fxWFIkQ5IjvTO8Uz1KHukBNhSVjIdreGPl9vcVed8kWY3LnTGPl1i5tbmVvrrvqptY S23XbvCmTP5OySzTC6yE4FTy8h0aNzD9McbjBGGfS0sE7ZrHaavlUfjzske1UtWehY3z YqSmrJbYrrd9xdPHoAZVpWpz+iF6ISbVeqlZogpmgJrc8QZ5MnoYAw61Q9DcwiMvckEs qNr9SPIMdC5mo1HQd/YGMkegJqvrwxzUGAmRe2tLcXyvWkBvjFAZNYt+bsWpgin+3Ra9 QVywe1sgGawzHZuKcxgjzpEnptYIkWXuBXUxovlJnpdpIYg3Rsk74K3Sn4Ze04QmWNDi BzTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si11771773pll.439.2018.12.02.13.15.47; Sun, 02 Dec 2018 13:16:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbeLBVPF (ORCPT + 99 others); Sun, 2 Dec 2018 16:15:05 -0500 Received: from www17.your-server.de ([213.133.104.17]:57444 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbeLBVPE (ORCPT ); Sun, 2 Dec 2018 16:15:04 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYlx-00017g-3L; Sun, 02 Dec 2018 21:55:25 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYlw-0003At-Ty; Sun, 02 Dec 2018 21:55:24 +0100 Subject: [PATCH] scsi: ipr: NULL check before some freeing functions is not needed. From: Thomas Meyer To: brking@us.ibm.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930052-1887660803-15-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 15 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9537,8 +9537,7 @@ static void ipr_free_cmd_blks(struct ipr } } - if (ioa_cfg->ipr_cmd_pool) - dma_pool_destroy(ioa_cfg->ipr_cmd_pool); + dma_pool_destroy(ioa_cfg->ipr_cmd_pool); kfree(ioa_cfg->ipr_cmnd_list); kfree(ioa_cfg->ipr_cmnd_list_dma);