Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6241421imu; Sun, 2 Dec 2018 13:17:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/XxuxAEQ4kmhWttklXNRTicZ7MWPbXLBPjZhrvfZj+DNSnQ37Jk+gVp49ro3/7kGazkxRjr X-Received: by 2002:a63:e516:: with SMTP id r22mr11499568pgh.256.1543785423389; Sun, 02 Dec 2018 13:17:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785423; cv=none; d=google.com; s=arc-20160816; b=rDuB45peNlah+pH+jLT3THV71aht3Wm1lBCY/X9ihSrsPKYnosNiZyjBRlh0NCXrGw m6e0Zc/TKXha+VAQzLZJ7wghAb5lBt4Ku8s3aryQOpf/M40qCYkYv4hk9TMuUWqY8zzE iiDFxrb5KfSrsQzLjAuF01yT03v6ATJnZAxVWJ74d230wh3OF25EEV8A+Zbv3KW0lAlV qFT2g6RkPlAFOn5bUxRrpjzqKIJUqfmWmkrd815PSTQqPo4KuvGdXeaPLxOzexFGadiH aIcoASlUrJgL3S9aOnVlgwhdtbeMv2AKRMp42rGwq0aKiuzJ9GmRP6RE41U/aaDfVuDC VdfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=VboYjjGH5O5tWJyeR3JgmTw0LhjXg238cc9mZAkJc1c=; b=bct74pszVgWmz7GFrFiZUBlweb9L/MfruCmrzt8RkUJsKfnm4Ap5gEy8x+YJGDKdua QyjRNy54Yd08jOAxgOCOoJdRtZptk7bMoKGAh5Fi9Mirypv3SKlSMI46CwpUhc6YlqOo dd8XqmGSiAInsKcfIHk0T25YaEc+1dsSWqiDsYt+ClEcwFcVIuyEBpcFQp7aHx5KW8y3 UEgttdUAq3PEbKQrRDdS66ofPJ2JVcfJZafAxgmNauwFMJfZzAtdc2bDFoNoFHLpazmB iqoglwGUqmZyXcv6F8YkrlNdFc+NBiF8qh64lmZ1PiP55jTpf/DTf8HfLpE2dpkfLQxB Z0yA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j66si12982651pfb.182.2018.12.02.13.16.49; Sun, 02 Dec 2018 13:17:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbeLBVPu (ORCPT + 99 others); Sun, 2 Dec 2018 16:15:50 -0500 Received: from www17.your-server.de ([213.133.104.17]:57638 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbeLBVPt (ORCPT ); Sun, 2 Dec 2018 16:15:49 -0500 X-Greylist: delayed 1230 seconds by postgrey-1.27 at vger.kernel.org; Sun, 02 Dec 2018 16:15:48 EST Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYlo-00015m-9K; Sun, 02 Dec 2018 21:55:16 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYlo-000248-3f; Sun, 02 Dec 2018 21:55:16 +0100 Subject: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed. From: Thomas Meyer To: khilman@kernel.org, nm@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930051-514988180-4-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 4 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info); - if (sr_info->dbg_dir) - debugfs_remove_recursive(sr_info->dbg_dir); + debugfs_remove_recursive(sr_info->dbg_dir); pm_runtime_disable(&pdev->dev); list_del(&sr_info->node);