Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6241676imu; Sun, 2 Dec 2018 13:17:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/V7djaE28F1aQ5hNqopmM/qN2pZaf8rKnjJHAHvi5305MbzDTIcxHR033oqLLhTUYH5LT6Y X-Received: by 2002:a63:7e5b:: with SMTP id o27mr11196342pgn.214.1543785443596; Sun, 02 Dec 2018 13:17:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785443; cv=none; d=google.com; s=arc-20160816; b=JEO9Tr6J05GLEPkMIBWG9cwe94CgYfw4G+XH8QIUWshGs7FiwXBtv1sxaMKo1y1jM7 Ez2bxp15dsggr6511cqn2kDc1S57F8eGnoE0JsMVychK3q0HEG5mUCQ8i3BkZTqv6w1z KOa9BFjCkwaLZm0uL8msHO72kE8QhIQqpR1Ex+SNfsUeQI05ZQGL5zXK17aLnASJIGLv gBrqza7PHxWjQymIY/HI3+7DWnpLFUwX3HEzNKoqAI03/65RV0tbGwhFuOmk8LJqdrUA 4vNiFV0iluQNlV6K3kTHLdZop7q94IwfMif/3WpKFna+D3d1PqAlklGLzq/NqJ2eddph ivjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=t1Hv4YQghljk9ncTbSdMiWQ3+i2u0sgvtkUTFMpVWlM=; b=ka0w4P4vTgaBj89FAGanxadF6yUEMWjb7y4I0AMRQ+W1kKwzrPaQH3rNvIw/1BmtlZ UJySsxU1pDhoNxnamEV0pIDZzA50kFX9zgV3iH62nZDUVH4LltHJZ+FJG3/pThUNgKet FyCDUgal2fEDOST+yz79jfgXIvBFpdlCim+BnR5WhyNeOMbZ/tYHKo5GuS1MEHLeXUy6 eCRLjwz8beMMSNkLPu//SgFrUG/h8lS/1A6groYHrW2nRPyb4BkB5N80TJF6mgSX7Mvz hpkgP3wiZMSx5u/bBWlIr9eNV9cdgtL+zR9giow3MXXMnbHOZRpPqMybg8PU1xtlr+Dp bzjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t136si13689842pfc.262.2018.12.02.13.17.09; Sun, 02 Dec 2018 13:17:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725987AbeLBVP7 (ORCPT + 99 others); Sun, 2 Dec 2018 16:15:59 -0500 Received: from www17.your-server.de ([213.133.104.17]:57690 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbeLBVP7 (ORCPT ); Sun, 2 Dec 2018 16:15:59 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYlt-000175-PR; Sun, 02 Dec 2018 21:55:21 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYlt-0002x3-Je; Sun, 02 Dec 2018 21:55:21 +0100 Subject: [PATCH] scsi: mpt3sas: NULL check before some freeing functions is not needed. From: Thomas Meyer To: sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930052-68443704-11-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 11 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4213,8 +4213,7 @@ _base_release_memory_pools(struct MPT3SA ioc->pcie_sg_lookup[i].pcie_sgl, ioc->pcie_sg_lookup[i].pcie_sgl_dma); } - if (ioc->pcie_sgl_dma_pool) - dma_pool_destroy(ioc->pcie_sgl_dma_pool); + dma_pool_destroy(ioc->pcie_sgl_dma_pool); } if (ioc->config_page) {