Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6247495imu; Sun, 2 Dec 2018 13:26:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/XMaL/2VL28Y7hK0FSmcRNxRY0gJYMuiFIlJqo0gxwwAr5ZKvy0ynofehzonHdHrgmgJr9q X-Received: by 2002:a63:5f95:: with SMTP id t143mr11370990pgb.395.1543785963181; Sun, 02 Dec 2018 13:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543785963; cv=none; d=google.com; s=arc-20160816; b=Aul9QtEOuN+8O3FGhbK4tIvYdePLYYRT2kJ7p1d/Urmsx6d+U0wAO+7ufxg9zTFcyD GU54I7pY6k/nQ9afl87J7w6Ik6lhJjp+RQFBCylnkVefb6Wbe8cPZ8I0Dvj4NopP3CXx M6LCqDFM7S+mU+FxQiDxS6qNNJW5QTmFniWDFwjCyNBGzC+eFpgY36vj+/VNZyEqwpD6 Oi/hCM8ru0mX/jKU40H9n3U6aGOO4mfgFfk78+4mqC+2jWJUQEYL+AmIaxUAP75eD1zV 0Cjus42RfrSUAfqgs392cva/9RmmwOiZSfOfP5VklCfQ2JDbm4l6zZ1O0woPQrz9X2ty hitA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent:date :in-reply-to:references:message-id:mime-version:to:from:subject; bh=1Mnt86773bF1fAm62BTYLft0yccMf2hdj9vsc8dATIE=; b=PbdR/IVcEXe2uCzBExOJeOR1J4OiR6TBryiUqe+ZqvwGizWPVZXKjdXKCA+oFcGo0E k/RJTRJZHHD+4jenjvgFVa5UuuTa7wlFnHvKG6HqrXYP2C13bpxn0iM4u6kITUi4cHf8 V3m8PhUKNp8osKDmq0DUV9ZN2537EMUMfx8HYRBihARZEPt8p5SzezboKAd7wjuOJbpO OIA/NqZf6Av8ShSfR3gvvHqFVtz7oZssYEl4UCceQ2bqg68QhSF8Icn7es80vZ9GLKNm Zadmgsw4byHaNH61uAwLWtYWJNW135eA0ouAymE3tcIA2Wbw1Z109hRia0UTNbTE42c8 qrjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si11913539plt.5.2018.12.02.13.25.48; Sun, 02 Dec 2018 13:26:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726000AbeLBVYs (ORCPT + 99 others); Sun, 2 Dec 2018 16:24:48 -0500 Received: from www17.your-server.de ([213.133.104.17]:60448 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbeLBVYr (ORCPT ); Sun, 2 Dec 2018 16:24:47 -0500 X-Greylist: delayed 1764 seconds by postgrey-1.27 at vger.kernel.org; Sun, 02 Dec 2018 16:24:46 EST Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gTYls-00016q-Kw; Sun, 02 Dec 2018 21:55:20 +0100 Received: from [2a02:908:4c28:3f60:fff6:43c5:695c:41d6] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gTYls-0002sv-Fv; Sun, 02 Dec 2018 21:55:20 +0100 Subject: [PATCH] platform/x86: intel_ips: NULL check before some freeing functions is not needed. From: Thomas Meyer To: dvhart@infradead.org, andy@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1543760930051-726829870-3-diffsplit-thomas@m3y3r.de> References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 3 Date: Sun, 02 Dec 2018 21:52:11 +0100 User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.100.2/25173/Sun Dec 2 15:13:44 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c --- a/drivers/platform/x86/intel_ips.c +++ b/drivers/platform/x86/intel_ips.c @@ -1300,8 +1300,7 @@ static const struct file_operations ips_ static void ips_debugfs_cleanup(struct ips_driver *ips) { - if (ips->debug_root) - debugfs_remove_recursive(ips->debug_root); + debugfs_remove_recursive(ips->debug_root); return; }