Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 2 Dec 2018 13:28:32 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH v3 0/7] zram idle page writeback
Message-ID: <20181202232832.hou645rlbvo7z5ar@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
References: <20181127055429.251614-1-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6shwijuvv6x6jsdl"
Content-Disposition: inline
In-Reply-To: <20181127055429.251614-1-minchan@kernel.org>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--6shwijuvv6x6jsdl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 27, 2018 at 02:54:22PM +0900, Minchan Kim wrote:
> Inherently, swap device has many idle pages which are rare touched since
> it was allocated. It is never problem if we use storage device as swap.
> However, it's just waste for zram-swap.
>=20
> This patchset supports zram idle page writeback feature.

Revisions look good to me. Will also try to give it some testing this
week.

Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>

> * Admin can define what is idle page "no access since X time ago"
> * Admin can define when zram should writeback them
> * Admin can define when zram should stop writeback to prevent wearout
>=20
> Detail is on each patch's description.
>=20
> Below first two patches are -stable material so it could go first
> separately with others in this series.
>=20
>   zram: fix lockdep warning of free block handling
>   zram: fix double free backing device
>=20
> * from v2
>   - use strscpy instead of strlcpy - Joey Pabalinas
>   - remove irqlock for bitmap op - akpm
>   - don't use page as stat unit - akpm
>=20
> * from v1
>   - add fix dobule free backing device - minchan
>   - change writeback/idle interface - minchan=20
>   - remove direct incompressible page writeback - sergey
>=20
> Minchan Kim (7):
>   zram: fix lockdep warning of free block handling
>   zram: fix double free backing device
>   zram: refactoring flags and writeback stuff
>   zram: introduce ZRAM_IDLE flag
>   zram: support idle/huge page writeback
>   zram: add bd_stat statistics
>   zram: writeback throttle
>=20
>  Documentation/ABI/testing/sysfs-block-zram |  32 ++
>  Documentation/blockdev/zram.txt            |  51 ++-
>  drivers/block/zram/Kconfig                 |   5 +-
>  drivers/block/zram/zram_drv.c              | 501 +++++++++++++++------
>  drivers/block/zram/zram_drv.h              |  19 +-
>  5 files changed, 446 insertions(+), 162 deletions(-)
>=20
> --=20
> 2.20.0.rc0.387.gc7a69e6b6c-goog
>=20

--=20
Cheers,
Joey Pabalinas

--6shwijuvv6x6jsdl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwEap8ACgkQ2rGdfm9D
tVLl1xAAr3tJ07J2CYMtIxO+HjgIOOKKxRD7L7RS0eTFhuOR3kq5vIYTyWUQMuLP
r18sOjS2BTQw4PnWutxcgWay9h/MO+Htm8+O06muiybgEwTHo1w+yRJyZGjc4tD1
QRDN9R9xHRu1djq0jlBYhVR7ARUt80n8Mp4JVzpPRqehofCXAnjNoE9TmxQphdN1
10TZYgtjOtt/aQHl8yGMwuby2Vwfo8XSzGXNd/khmI76tZn82TVheAioyzDXT6i0
+pB1Hglktvdsg+AGfA9IUEnbnyihlpbjaIlDVyWoe0mcar/BjBdlvD+6G0PzShzs
u32ZjrC4qe6I2FL+nENoXsb3efjVF7QBOIaysVMOUFas+4h1a8oKj0qp5xSS5R6U
mNQ5DiBYCSdaXPctN+E00NGoSoBCLZlWAh9g15xtxdA5PTz0282SlRQ8w8UKhXUe
OhU/lryDluYV+Fz8OlWFsRWHE3/Rmb20KVNNkld4E98tPzqoTeRqa670nJFEj7Xg
nhtUL35nZ9aiEAZpHqQE87UZAjWB+8uuYYSaiDAz7RFbWknOoudvI2B2OAEo2/u4
/l5PL4LHm5m/dTLgJIsHJIijTAVRqc2lv0ZOL6UQjO4PHu/O0kPYLAn3GDqveUkS
ld5f361vqLY3oVGeX2h90vfrJH+5ke/G7F+MDk9mA6+CoLQhp6g=
=mDBH
-----END PGP SIGNATURE-----

--6shwijuvv6x6jsdl--