Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6382161imu; Sun, 2 Dec 2018 16:54:28 -0800 (PST) X-Google-Smtp-Source: AFSGD/XgaH2Pgyq0lb+Lb1+DChYts4pNOjTDhZokccjB2nxpsMb9AgovpNo0BKVaB8iMrQtheCI1 X-Received: by 2002:a63:f615:: with SMTP id m21mr11962036pgh.428.1543798468589; Sun, 02 Dec 2018 16:54:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543798468; cv=none; d=google.com; s=arc-20160816; b=EcviMMs4Nkdf1t8zp++QTYNng3Y3XaOQfC9KFk13XiL1Ubouob7JloaWaf1ucCMn32 UtXZfD+MCgbUDdB/kuODRWhrGrZwb5u7qvfPcm6zV8CctJWLKYOk+kcJpBiKPwucByN7 RAYj5JpGhUlOG5F9vxRKWwviBCeJhmad3hvtL3KfaYoFNQIDz9oFg50PP294VYQf4tX+ xT6wTehQmqTY9pr8yfusFXWtRXUAxYnbrbA9ZjduXXWPZvtzK/KPKXHFYu5XoGrE6sia w98Ii3a6VYJEytr4LZLuKNvmyWrzGOd3yt/SFQ7p92XdqJp8piewgVNIooizaiFN0vhe eHeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:to:from; bh=uXOsOIP6q9L91PE+k+sjMUVl6su4rLg8P4fmn2vJYWY=; b=Hbrz6SHOf/U07X3oCEC4joB3IuouJesq2Opzs8wr8XkbGomcX3eCUgKvPJwri+irm8 IXa/e4mCZ22H8rWQE+8wfqQETvkQsx/DEyrm48n3xUSPpNUF+3O0YGawv+nrjQ2u4kSP xnQYoszW/JtemK47SVUaB8CaX2S+zi3dEwP02hWvcIHnYOkqsb/2DrmgmM6Jk2/NRoxm TjkCV1k8IlkNi9CRaJ//VwSbW3jdVTIplvspEaUsZ0aMj+jOZfRuxxkoqJEGRe0ZkZyg tv6lPape9PNbKuk1CeZ5Isfl5TQMT2FhrJD6cXE/wsJ3jyzptmvEQ0DvIWHu+ANI64k6 JpDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c26si11436620pgm.210.2018.12.02.16.54.14; Sun, 02 Dec 2018 16:54:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbeLCAxe (ORCPT + 99 others); Sun, 2 Dec 2018 19:53:34 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37414 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725795AbeLCAxe (ORCPT ); Sun, 2 Dec 2018 19:53:34 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wB30mcPi002664 for ; Sun, 2 Dec 2018 19:53:29 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2p4sns1b7t-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 02 Dec 2018 19:53:29 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Dec 2018 00:53:27 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 3 Dec 2018 00:53:25 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wB30rOeQ328144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Dec 2018 00:53:24 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 136985204F; Mon, 3 Dec 2018 00:53:24 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id B47BD52051; Mon, 3 Dec 2018 00:53:23 +0000 (GMT) Received: from tungsten.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 2111EA026F; Mon, 3 Dec 2018 11:53:22 +1100 (AEDT) From: Sam Bobroff To: daniel@ffwll.ch, airlied@redhat.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] drm/ast: Fix connector leak during driver unload Date: Mon, 3 Dec 2018 11:53:21 +1100 X-Mailer: git-send-email 2.19.0.2.gcad72f5712 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18120300-0028-0000-0000-000003250A4D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18120300-0029-0000-0000-000023E10A85 Message-Id: <1e613f3c630c7bbc72e04a44b178259b9164d2f6.1543798395.git.sbobroff@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-02_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=781 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030007 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When unloading the ast driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_crtc_force_disable_all() in ast_fbdev_destroy(). Signed-off-by: Sam Bobroff --- v2 * Changed to use drm_crtc_force_disable_all(). drivers/gpu/drm/ast/ast_fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index 0cd827e11fa2..de26df0c6044 100644 --- a/drivers/gpu/drm/ast/ast_fb.c +++ b/drivers/gpu/drm/ast/ast_fb.c @@ -263,6 +263,7 @@ static void ast_fbdev_destroy(struct drm_device *dev, { struct ast_framebuffer *afb = &afbdev->afb; + drm_crtc_force_disable_all(dev); drm_fb_helper_unregister_fbi(&afbdev->helper); if (afb->obj) { -- 2.19.0.2.gcad72f5712