Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Davidlohr Bueso <dave@stgolabs.net>, paulmck@linux.ibm.com,
        Josh Triplett <josh@joshtriplett.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Will Deacon <will.deacon@arm.com>
Cc:     linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH v2] locktorture: Fix assignment of boolean variables
Date:   Mon, 3 Dec 2018 10:23:18 +0800
Message-Id: <20181203022318.58083-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Fix the following warnings reported by coccinelle:

kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:949:3-20: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:682:2-19: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:688:2-19: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:648:2-20: WARNING: Assignment of bool to 0/1
kernel/locking/locktorture.c:654:2-20: WARNING: Assignment of bool to 0/1

This patch also makes the code more readable.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Davidlohr Bueso <dave@stgolabs.net>
CC: "Paul E. McKenney" <paulmck@linux.ibm.com>
CC: Josh Triplett <josh@joshtriplett.org>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@redhat.com>
CC: Will Deacon <will.deacon@arm.com>
CC: linux-kernel@vger.kernel.org
---
 kernel/locking/locktorture.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index 7d0b0ed74404..cd95c01491d8 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -645,13 +645,13 @@ static int lock=5Ftorture=5Fwriter(void *arg)
 		cxt.cur=5Fops->writelock();
 		if (WARN=5FON=5FONCE(lock=5Fis=5Fwrite=5Fheld))
 			lwsp->n=5Flock=5Ffail++;
-		lock=5Fis=5Fwrite=5Fheld =3D 1;
+		lock=5Fis=5Fwrite=5Fheld =3D true;
 		if (WARN=5FON=5FONCE(lock=5Fis=5Fread=5Fheld))
 			lwsp->n=5Flock=5Ffail++; /* rare, but... */
=20
 		lwsp->n=5Flock=5Facquired++;
 		cxt.cur=5Fops->write=5Fdelay(&rand);
-		lock=5Fis=5Fwrite=5Fheld =3D 0;
+		lock=5Fis=5Fwrite=5Fheld =3D false;
 		cxt.cur=5Fops->writeunlock();
=20
 		stutter=5Fwait("lock=5Ftorture=5Fwriter");
@@ -679,13 +679,13 @@ static int lock=5Ftorture=5Freader(void *arg)
 			schedule=5Ftimeout=5Funinterruptible(1);
=20
 		cxt.cur=5Fops->readlock();
-		lock=5Fis=5Fread=5Fheld =3D 1;
+		lock=5Fis=5Fread=5Fheld =3D true;
 		if (WARN=5FON=5FONCE(lock=5Fis=5Fwrite=5Fheld))
 			lrsp->n=5Flock=5Ffail++; /* rare, but... */
=20
 		lrsp->n=5Flock=5Facquired++;
 		cxt.cur=5Fops->read=5Fdelay(&rand);
-		lock=5Fis=5Fread=5Fheld =3D 0;
+		lock=5Fis=5Fread=5Fheld =3D false;
 		cxt.cur=5Fops->readunlock();
=20
 		stutter=5Fwait("lock=5Ftorture=5Freader");
@@ -700,7 +700,7 @@ static int lock=5Ftorture=5Freader(void *arg)
 static void =5F=5Ftorture=5Fprint=5Fstats(char *page,
 				  struct lock=5Fstress=5Fstats *statp, bool write)
 {
-	bool fail =3D 0;
+	bool fail =3D false;
 	int i, n=5Fstress;
 	long max =3D 0, min =3D statp ? statp[0].n=5Flock=5Facquired : 0;
 	long long sum =3D 0;
@@ -915,7 +915,7 @@ static int =5F=5Finit lock=5Ftorture=5Finit(void)
=20
 	/* Initialize the statistics so that each run gets its own numbers. */
 	if (nwriters=5Fstress) {
-		lock=5Fis=5Fwrite=5Fheld =3D 0;
+		lock=5Fis=5Fwrite=5Fheld =3D false;
 		cxt.lwsa =3D kmalloc=5Farray(cxt.nrealwriters=5Fstress,
 					 sizeof(*cxt.lwsa),
 					 GFP=5FKERNEL);
@@ -946,7 +946,7 @@ static int =5F=5Finit lock=5Ftorture=5Finit(void)
 		}
=20
 		if (nreaders=5Fstress) {
-			lock=5Fis=5Fread=5Fheld =3D 0;
+			lock=5Fis=5Fread=5Fheld =3D false;
 			cxt.lrsa =3D kmalloc=5Farray(cxt.nrealreaders=5Fstress,
 						 sizeof(*cxt.lrsa),
 						 GFP=5FKERNEL);
--=20
2.19.1