Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 3 Dec 2018 11:41:46 +0900
From:   Minchan Kim <minchan@kernel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH v3 7/7] zram: writeback throttle
Message-ID: <20181203024146.GA149587@google.com>
References: <20181127055429.251614-1-minchan@kernel.org>
 <20181127055429.251614-8-minchan@kernel.org>
 <20181129022358.GA6379@jagdpanzerIV>
 <20181202231829.GA21560@google.com>
 <20181203023040.GA427@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181203023040.GA427@jagdpanzerIV>
User-Agent: Mutt/1.10.1+60 (6df12dc1) (2018-08-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 03, 2018 at 11:30:40AM +0900, Sergey Senozhatsky wrote:
> On (12/03/18 08:18), Minchan Kim wrote:
> > 
> > Per andrew's comment:
> > https://lkml.org/lkml/2018/11/27/156
> > 
> > I need to fix it to represent 4K always.
> 
> Aha.
> 
> Then we need to increase bd_writes PAGE_SIZE/4K times in writeback_store()?
> 
>    wb_count = atomic64_inc_return(&zram->stats.bd_writes);
>    ...
>    if (wb_limit != 0 && wb_count >= wb_limit)
>        zram->stop_writeback = true;
> 
> bd_wb_limit is in 4K units; but in writeback_store() we alloc a full page
> and write it to the backing device. So the actual number of written bytes
> can be larger on systems with page_size > 4K. Right?

Hey Sergey,

I changed interface in recent version v4. I belive it would be more
straigtforward for user. Could you review it?

Thanks!