Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6485779imu; Sun, 2 Dec 2018 19:38:40 -0800 (PST) X-Google-Smtp-Source: AFSGD/WY0DA6JbxC0copzJ6V1piVlia6Sm6LGQj+dTl1UbeE2xkouQFQGxno+tmNWnbcIcbBNg2d X-Received: by 2002:a62:46d0:: with SMTP id o77mr14476250pfi.172.1543808319956; Sun, 02 Dec 2018 19:38:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543808319; cv=none; d=google.com; s=arc-20160816; b=Ti8A6odNAtAzXuAn85LVFOX0E84nhDHcu3is+JeH7IzA7fP/LgN75dkEqvNipghVV5 P2YBcgVVH1dDJsfhdZHYwDX8ngarY42gnbrEpGr4e2miNjI9IPpvNOXrWBLpQAbsjHJR mcro/mxLCecABAygmn8suTgbXEB+LZjMPjlemFqN9u4wKfoJwSUgVYouACeEvdVCAoAW kHTuh9g92M2I5Mm6dpBAWmS60AQO0DWvN0YKOTItqtPmxGLItOf3k2NmSbXyJ8Lhjead QMMTtmhVdifMWSNBcN/yI3uVCFJ0RBIxj/WI4VS9t3DN/zLIFwZtdulSlsEpWwBD4wqc 1IfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=cjfsQWOKigLeA72jmzn+Ohyghsn42SCqMOuPnXsRS/4=; b=I1OsEpCUbA4RGUBSk1D3LKvbANFofHjTssnvjr7YKMqCqDQYKFU6VqyEI4/M+Y8WSd p1aUSH5PUKOpMlOsqfuEMYGh51EZE+Jkpzj4TcdjVCyKmo40xrg8accQcD07F12OuNl/ 42M299fmAyFvS33UXMyBLfj18DugjM3XrmC8eblrwGudlPk24Es3yLz8VHth1TZqCtri vj7a/Tkh9r1H1hl5bBPL19uL4wUnLCVBUXMNfTuh2QE59XoH7SJdUq71r09zBohOOwZr BuB9t/BZ2wfU3jcF9tCmn9CyUqzpPxwUGtBIAibbnfHrdoTsp+AaZO333zzsBKsgecD7 h5Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nigauri-org.20150623.gappssmtp.com header.s=20150623 header.b=J5kyt5+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si11362692pgc.41.2018.12.02.19.38.23; Sun, 02 Dec 2018 19:38:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nigauri-org.20150623.gappssmtp.com header.s=20150623 header.b=J5kyt5+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbeLCDhk (ORCPT + 99 others); Sun, 2 Dec 2018 22:37:40 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:52280 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbeLCDhk (ORCPT ); Sun, 2 Dec 2018 22:37:40 -0500 Received: by mail-it1-f194.google.com with SMTP id i7so7125372iti.2 for ; Sun, 02 Dec 2018 19:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nigauri-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cjfsQWOKigLeA72jmzn+Ohyghsn42SCqMOuPnXsRS/4=; b=J5kyt5+JprtGir3Ixayfd0HUF/OFoyYYOScfGubiK/YnVxgRh7gaVdCmnsACge8XnN 8vcNpCGYmopIbp6p6H6x8lbbBfPHHP8/X9+AnOjBjGuDKL/tRrLwGQ+vOEZ8pikys2JK tnsxKJ+5bdse6zU7P0Yj98swwHYA1YV0ED/MkFshcBp13DmyiD6n9tyJljAm/APSWyfx 0YbfoVlchIYGk86ymtvEQGmSRgwQwVedzht4seYw9VrX/aGpUk3sXUFwtuCS/5VTz8Ht NGeCt5NrpxQVhZhvr1xBGGEzJi2rax6A+afdTwppqf1Eh66CPUHWUbknGyh4gVlCYP5l gV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cjfsQWOKigLeA72jmzn+Ohyghsn42SCqMOuPnXsRS/4=; b=FovRJL1nUj6KmaMu65pz+u1oxgG4D4au27EYGgfCPkJA/jn8q2Fj31WgC+bkADh+eU kLCGzUSFmALfMYg3OwQe5Hfwk5DWy3TSrP9H5qIBDmxlq7neENkR0Jf8kX8Uk2jWAUJL qvPtqm5xiucLaD8dEopfg5mFvW9ULnAKKvF4t8pU+3fAAxMwEagiP0ZzJsAVZ1uZTFI1 W3FLXHhP4Gge4Er661aXsAeDDDrNWJ93xQxCAHUj4xh0z/0TXpCn9xM4pH/InAO6oMf4 xAmD+z6bIKDoxEOUEpA5f6058X4Zems8gq52rGgZMXmwefqHhfh+YgrtcZIPerNfd6N9 6CyQ== X-Gm-Message-State: AA+aEWZ72FMVi79qzThKRzXk6s4nwAiby6ikMf1Rep8yXylMR7Pfyfgv CeTCZcdY24eq8Yl2K55NoDc4HH3Im2bSfPE8PGY/ X-Received: by 2002:a24:130a:: with SMTP id 10mr6565648itz.58.1543808253820; Sun, 02 Dec 2018 19:37:33 -0800 (PST) MIME-Version: 1.0 References: <1488160439-7140-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> In-Reply-To: From: Nobuhiro Iwamatsu Date: Mon, 3 Dec 2018 12:37:11 +0900 Message-ID: Subject: Re: [PATCH v5 0/5] pstore: ramoops: support multiple pmsg instances To: keescook@chromium.org Cc: anton@enomsg.org, ccross@android.com, tony.luck@intel.com, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org # Remove nobuhiro.iwamatsu.kw@hitachi.com from To. Hi, I am already leaving Hitachi. However, I would like to merge these patches into the kernel. I will resume work. Best regards, Nobuhiro 2018=E5=B9=B411=E6=9C=8830=E6=97=A5(=E9=87=91) 8:33 Kees Cook : > > On Sun, Feb 26, 2017 at 5:54 PM Nobuhiro Iwamatsu > wrote: > > The following series implements multiple pmsg. This feature allows user= space > > program to control individual content aging or priority. > > I'd like to take a look at this series again, if you're still > interested in upstreaming it. :) There were a lot of things that > needed refactoring in pstore to sanely deal with this, and I think > we're there now. Is this still desired? > > Thanks, > > -Kees > > > > > If a pstore backend module(e.g. ramoops) requires the multiple pmsg ins= tances > > when registering itself to pstore, multiple /dev/pmsg[ID] are created. = Writes > > to each /dev/pmsg[ID] are isolated each other. After reboot, the conten= ts are > > available in /sys/fs/pstore/pmsg-[backend]-[ID]. > > > > In addition, we add multiple pmsg support for ramoops. We can specify m= ultiple > > pmsg area size by its module parameter as follows. > > > > pmsg_size=3D0x1000,0x2000,... > > > > I did check the operation of this feature on CycloneV (socfpga) Helio b= oard. > > > > v5: > > Add commit: "pstore: Change parameter of ramoops_free_przs()" > > - I forgot addition to previous patch series. > > Update commit: "pstore: support multiple pmsg instances" > > - Fix comment. > > - Fix initialization of num_pmsg. > > > > v4: > > Rebase to 4.10-rc5 > > The following patches have been removed from this series as similar f= unctions > > were modified by other commit. > > - pstore: Replace four kzalloc() calls by kcalloc() in ramoops_ini= t_przs() > > - pstore: Change parameter of ramoops_free_przs() > > - pstore: Rename 'przs' to 'dprzs' in struct ramoops_context > > - ramoops: Rename ramoops_init_prz() to ramoops_init_dprzs() > > > > v3: > > Rebase to v4.8. > > Split patch. > > merged device_create(). > > Remove Blank lines. > > Update documentiation of DT binding. > > Update parsing function of ramoops_pmsg_size, add NULL termination. > > Update module parameters for pmsg_size list. > > > > Hiraku Toyooka (2): > > pstore: support multiple pmsg instances > > selftests/pstore: add testcases for multiple pmsg instances > > > > Nobuhiro Iwamatsu (3): > > pstore: Change parameter of ramoops_free_przs() > > ramoops: Add __ramoops_init_prz() as generic function > > ramoops: support multiple pmsg instances > > > > Documentation/admin-guide/ramoops.rst | 22 ++ > > .../bindings/reserved-memory/ramoops.txt | 6 +- > > fs/pstore/pmsg.c | 23 +- > > fs/pstore/ram.c | 317 +++++++++++++= +++----- > > include/linux/pstore.h | 1 + > > include/linux/pstore_ram.h | 8 +- > > tools/testing/selftests/pstore/common_tests | 21 +- > > .../selftests/pstore/pstore_post_reboot_tests | 27 +- > > tools/testing/selftests/pstore/pstore_tests | 14 +- > > 9 files changed, 342 insertions(+), 97 deletions(-) > > > > -- > > 2.11.0 > > > > > -- > Kees Cook --=20 Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6