Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Bernie Thompson <bernie@plugable.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH] udlfb: fix potential NULL pointer dereference in dlfb_usb_probe
Date:   Mon, 3 Dec 2018 14:21:25 +0800
Message-Id: <20181203062125.34880-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This patch fixes a possible null pointer dereference in
dlfb=5Fusb=5Fprobe, detected by the semantic patch deref=5Fnull.cocci,
with the following warning:

drivers/video/fbdev/udlfb.c:1704:11-15: ERROR: dlfb is NULL but dereference=
d.

The following code has potential null pointer references:
1597         /* usb initialization */
1598         dlfb =3D kzalloc(sizeof(*dlfb), GFP=5FKERNEL);
1599         if (!dlfb) {
...
1601             goto error;
1602         }
...
1703 error:
1704         if (dlfb->info) {
1705                 dlfb=5Fops=5Fdestroy(dlfb->info);
1706         } else if (dlfb) {
1707                 usb=5Fput=5Fdev(dlfb->udev);
1708                 kfree(dlfb);
1709         }

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Bernie Thompson <bernie@plugable.com>
CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
CC: linux-fbdev@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
---
 drivers/video/fbdev/udlfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 070026a7e55a..df37cfaa2362 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1701,7 +1701,7 @@ static int dlfb=5Fusb=5Fprobe(struct usb=5Finterface =
*intf,
 	return 0;
=20
 error:
-	if (dlfb->info) {
+	if (dlfb && dlfb->info) {
 		dlfb=5Fops=5Fdestroy(dlfb->info);
 	} else if (dlfb) {
 		usb=5Fput=5Fdev(dlfb->udev);
--=20
2.19.1