Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6676635imu; Mon, 3 Dec 2018 00:37:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/X4hLeMIpMnXakG9b0gqwJTFikqG7M6EWtRwEVfprzlf+52JJX8pFYPt4QjdoYJIn/WbyRT X-Received: by 2002:a63:396:: with SMTP id 144mr12680370pgd.68.1543826225761; Mon, 03 Dec 2018 00:37:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543826225; cv=none; d=google.com; s=arc-20160816; b=f6d7TiYXeHnGh9L+O6DsULRchQD2o9pwaoT1JQaAkfQDFPVyK240eANEz3uw9DvU6d MuHl5d+vVS3B3Nnx6xQxUR+Js4niP1FpRnucG6lTDJn7kTnYj0vKtdaSARac1OllDWEs PD5ptbZ0fb3U8I3s+ETtACrMsUlLAi39/jwMAeiON/I/tnIyTWk0/IFjfGI6N6PQwsgq v2kbqVoOxcz/ujxhoJ4lTZ/srx8linpLUtwSnqEK5I63ujmkXs042XcSXnH8jwJqIh8Y OWdYBkK/vmxqZDj8pzvHLc2VGupKaUEmGtbAV1q+Jo4A+LnHpk2FEcnRGBWfKRj1kRoG pEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Kyx2QCID12UOPm/FFHZm76pDnAa5udfNIhFmf6fCX50=; b=Z50WXo7ZgO5CUXuHlm5SMxgQO5PJH13OZK0EWJ/hxJnDuDHr25WpUfzkfPsljcnCqJ joTi4+THlcH2jg9O2H3VKCVP/8Inx9H6Nc39Y6G4IG7/Pwr2csXFkysK75XclX6+7bvg UaRXzts85tZn0vJlDPpyqsdjaryXXgi1MEIYy8L+hC1eOBJ2sLKBFznqYRCJTDORttk2 afzYbpnROUnDtdWuOlSc78WMYaDa/hp7zVYuIDr+nHD7r00KsQeu03BztnYeFbDNAy0f q7KU5668r2G+KNL42x3VPcE+aJCueQCbSAZBPzGgHn49p8NnixrItblk6Rq2T4/R0Lj2 /dhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=iQJqk8I0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b34si13454620pld.305.2018.12.03.00.36.50; Mon, 03 Dec 2018 00:37:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=iQJqk8I0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725925AbeLCIfK (ORCPT + 99 others); Mon, 3 Dec 2018 03:35:10 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34782 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbeLCIfJ (ORCPT ); Mon, 3 Dec 2018 03:35:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kyx2QCID12UOPm/FFHZm76pDnAa5udfNIhFmf6fCX50=; b=iQJqk8I0H3e+RUZ98xoNzBmsB pqoeSsKOU9Dm25Ta+QLNAPjyRHExviYVAdqkCY6tWNfqm3HY1VQUMy1ok2Tm1U3dmry8X68JHgziB J3eFCaHwjIqlMZ5jr8cVmF8hkQqzQ1bH1loOyRYjcGl004eMv1v7xhEsJkrSfwFIY4e09kX0nYyOZ dhjdZPOl2baFB+t93Pf+NWjj150MdBQgOnKcoDiX+tQWrtPu5utvVcEfpuxDzZ+jEUD5MpGevN/vN Ozl8iJBDPtBfKxmX7SEJ0wfjeJwCIzPnq4k83CYeG/01V1dilJx0oi4tVJNm5ujB4TDR0b19bUTUD XxUTFk2qg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTjh1-0002I0-8m; Mon, 03 Dec 2018 08:35:03 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C86BA2029F873; Mon, 3 Dec 2018 09:35:00 +0100 (CET) Date: Mon, 3 Dec 2018 09:35:00 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Wen Yang , Davidlohr Bueso , Josh Triplett , linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn, mingo@redhat.com, will.deacon@arm.com Subject: Re: [PATCH] locktorture: Fix assignment of boolean variables Message-ID: <20181203083500.GH11614@hirez.programming.kicks-ass.net> References: <20181201083149.36972-1-wen.yang99@zte.com.cn> <20181201203700.GW4170@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181201203700.GW4170@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > Fix the following warnings reported by coccinelle: > > > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:949:3-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:682:2-19: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:688:2-19: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:648:2-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:654:2-20: WARNING: Assignment of bool to 0/1 > > > > This patch also makes the code more readable. > > > > Signed-off-by: Wen Yang > > CC: Davidlohr Bueso > > CC: "Paul E. McKenney" > > CC: Josh Triplett > > CC: linux-kernel@vger.kernel.org > > Adding the current maintainers on CC. So I strongly disagree with this. Anybody that has trouble with 0/1 vs false/true needs to stay the heck away from C. I would suggest we delete that stupid coccinelle scripts that generates these pointless warns.