Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 3 Dec 2018 11:15:06 +0100
From:   Phil Sutter <phil@nwl.cc>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniel Axtens <dja@axtens.net>,
        Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
        Stefano Brivio <sbrivio@redhat.com>,
        Yonghong Song <yhs@fb.com>, Paolo Abeni <pabeni@redhat.com>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH RFC 15/15] net: replace **** with a hug
Message-ID: <20181203101506.GM30790@orbyte.nwl.cc>
Mail-Followup-To: Phil Sutter <phil@nwl.cc>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniel Axtens <dja@axtens.net>,
        Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
        Stefano Brivio <sbrivio@redhat.com>, Yonghong Song <yhs@fb.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com>
 <20181130192737.15053-16-jarkko.sakkinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181130192737.15053-16-jarkko.sakkinen@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 30, 2018 at 11:27:24AM -0800, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.

This is incorrect: The patch doesn't replace '****', but 'fuck' instead.

> -			/* Fuck, we are miserable poor guys... */
> +			/* Hug, we are miserable poor guys... */

I fail to see the benefit from doing that. If I wrote: "Hug you you
hugging hug", you would still find it offensive as long as you know what
"hug" is supposed to translate into. And if you don't, you'll soon find
out.

A more constructive approach to replacing "fuck this and that" than
simply applying 's/fuck/whatever/' would be to provide details what
exactly is so bad about this and that. Of course that's not possible
without considerable effort, unlike your approach which doesn't alter
what is written but merely which words are used for it.

Cheers, Phil