Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6791491imu; Mon, 3 Dec 2018 02:56:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/WnUVmit+p+OpLsh/qgH6WovZXhCasD1eavJWXQWezRw7wS1Vd833yZL1/QS16hmOD8DqFK X-Received: by 2002:a62:178f:: with SMTP id 137mr15311053pfx.226.1543834595583; Mon, 03 Dec 2018 02:56:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543834595; cv=none; d=google.com; s=arc-20160816; b=PGdKgvQqqaP/+IzqJB+qJ7y9+rh6C4pfPUgBxJ5wQVVYR3tpB7bAKSiB6cvN5gm3pF Q0xCboBfu3eDqBTJJUO8Dkq/zmsTjwZtxiWfv9NngZBs/oFCzrUjcHpT7Q7Nx39E+aEN jd9/byJifgde9KtH6igjNUxUOkPP9zi433bZGolDKnIrweZhgXb54OsLvnxOqDYOwB6k 7oPEoRqTg8psaqAl644w9RDvgibbtsnZdLVhI2ujst72IffH2oHoCIjDGpLoUuJtcdv9 V8jOOdV+E5QFqWNAVyIwwsj6Poh+mzr+oTHtNtQ3jCUOY+Z/rWViWmvMmdV1pWuLYZiC OySw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:in-reply-to:references :subject:cc:to:from:date:message-id; bh=Ag7djBDjmH25ogid7rF9F3wDGK7nFSheB2/PmdFovfE=; b=0xGz5ylpsPamzBB59V5+Yl1aJ9FzjwqKjs1H3o0ZHkNd5BzFw0wNt7e82dpCAzsZan ZSyQpAgN80LEiZMHLtDsUpgCohHd/Q/iOkJrmQ5ZUjwFHcHHDARChtY9WIJFhvo9LIva vCYauNuRrqdJzFUOPwC0zBtfxhHb/4Adf0TIsXEJ0kUDrDPtCeD+m9QV+1gDhBBsi3Wm STY0MzVvCzA74JvX27T6kiYGwUYp/HI07nUPTmtd8dDM5XJziL8stF6hZykSFUYs8DFw kmc3nYN/WdV5dTul/QH/DaBd56RbMlWCERZFwzWHP8e/nY6qdBZHqF2XeLBmALIUXlWB gSYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n12si12363042pgb.563.2018.12.03.02.56.20; Mon, 03 Dec 2018 02:56:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbeLCKzi convert rfc822-to-8bit (ORCPT + 99 others); Mon, 3 Dec 2018 05:55:38 -0500 Received: from prv1-mh.provo.novell.com ([137.65.248.33]:51019 "EHLO prv1-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbeLCKzi (ORCPT ); Mon, 3 Dec 2018 05:55:38 -0500 Received: from INET-PRV1-MTA by prv1-mh.provo.novell.com with Novell_GroupWise; Mon, 03 Dec 2018 03:55:05 -0700 Message-Id: <5C050B87020000780020222E@prv1-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 18.1.0 Date: Mon, 03 Dec 2018 03:55:03 -0700 From: "Jan Beulich" To: "Marek Marczykowski" Cc: "Dwayne Litzenberger" , "Stefano Stabellini" , "xen-devel" , "Boris Ostrovsky" , "Juergen Gross" , Subject: Re: [Xen-devel] [PATCH 1/2] xen-pciback: Fix error return in bar_write() and rom_write() References: In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 02.12.18 at 18:47, wrote: > From: Dwayne Litzenberger > > Signed-off-by: Dwayne Litzenberger At least in the kernel world I think your own SOB is expected here. Also the description would better be non-empty, explaining under what conditions failure was observed (and wrongly ignored), or whether instead the change is solely "just in case". Some stylistic adjustments would also seem on order, but since I'm not entirely certain about the kernel policy in this regard I'll omit respective remarks. Jan