Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6894076imu; Mon, 3 Dec 2018 04:41:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/VHgOwafV96wPZTAapT1EursknIRMpElpuDU4qynC9hWk9G6UPk4gkOoCMTn6K2tEDepMKl X-Received: by 2002:a62:44d8:: with SMTP id m85mr15961276pfi.164.1543840892286; Mon, 03 Dec 2018 04:41:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543840892; cv=none; d=google.com; s=arc-20160816; b=HTnL3raeCwYeA5FTKjLUqNPDuDerX2DuP/tNOBmvix0FyYn8z7ok/CNLm2duTKbl4x TI8AUmu3bghjPX5JLOuGzCE2K70VoWCcMZJ2ua/0oDOAmQmzJg5Kht/kZt3F4NphNvB5 unuxtjY40lC3A/rfPim6jen4UpYuTnAFmEhM7c/SN7KqWg60PUeCLzL91ykOIldWFoAe fFEeNEr9SGmqkW1B/uu+5dmNVlrle6dBTsfCZ8vGlc1+YCCQT2DSbM38HwIu9uw/iD9g IjRIVfRng3i0DIGk2bXwWxYjtZQtq0WrRQZF+bkWHjus+tZ4wVOgk+7EcV9zOzviQdlG k5Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CpVBUqwWDJG1u75Nudd8H7ShCG/apjVEcu013Z+kCX0=; b=EnfyvIRS4tpncHuPDe1Aw+F3Bi0t/4scofya3HUJrhVektGX7hYH1Xv9/c+RhspkyW w9cWJ3knEFH9qqgAqf+Oa4GzVIqD+ftvYfryAB4Rln0OOu3qOPOw/JSPWw4FrrCVY4po J02uCSBl4Wxnl/bdRqUSzY0++93g0ViIDA7rDJClLMogoUhphiZfW5uRYDZJjWNejXKt mYUuoCrRPa3i8Uly2EOcldivSHgVLBcqRiwfxwNXwfvyN8F6l6/H/N9gn8NJMDsSGd6F JNjKiu/Mpz33VODqS7GwaBFgDoUsOq/c6X6ATQrsVd9jeZ4hzcrRBRH1mRPHJeG4rK+L vQWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si11896092pgv.111.2018.12.03.04.41.11; Mon, 03 Dec 2018 04:41:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbeLCMl0 (ORCPT + 99 others); Mon, 3 Dec 2018 07:41:26 -0500 Received: from foss.arm.com ([217.140.101.70]:36488 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbeLCMl0 (ORCPT ); Mon, 3 Dec 2018 07:41:26 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B4231688; Mon, 3 Dec 2018 04:40:32 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 655A03F614; Mon, 3 Dec 2018 04:40:32 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 538511AE1062; Mon, 3 Dec 2018 12:40:52 +0000 (GMT) Date: Mon, 3 Dec 2018 12:40:52 +0000 From: Will Deacon To: Rob Herring Cc: Michal Simek , Mark Rutland , Catalin Marinas , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linuxppc-dev , Tom Rini , Kumar Gala , Grant Likely , Arnd Bergmann , Linus Walleij , Pantelis Antoniou , Bjorn Andersson , Olof Johansson , Mark Brown , Geert Uytterhoeven , Matthias Brugger , linux-mediatek@lists.infradead.org, Frank Rowand , Jonathan Cameron Subject: Re: [PATCH 12/36] dt-bindings: arm: Convert cpu binding to json-schema Message-ID: <20181203124039.GA25097@arm.com> References: <20181005165848.3474-1-robh@kernel.org> <20181005165848.3474-13-robh@kernel.org> <035ae23f-3c92-ffd9-0753-abbd604c5c02@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 12:00:05PM -0600, Rob Herring wrote: > On Thu, Nov 8, 2018 at 2:49 AM Michal Simek wrote: > > > > Hi Rob, > > > > On 05. 10. 18 18:58, Rob Herring wrote: > > > Convert ARM CPU binding to DT schema format using json-schema. > > > > > > Cc: Mark Rutland > > > Cc: Matthias Brugger > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: linux-mediatek@lists.infradead.org > > > Signed-off-by: Rob Herring > > > --- > > > .../devicetree/bindings/arm/cpus.txt | 490 ----------------- > > > .../devicetree/bindings/arm/cpus.yaml | 503 ++++++++++++++++++ > > > 2 files changed, 503 insertions(+), 490 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/arm/cpus.txt > > > create mode 100644 Documentation/devicetree/bindings/arm/cpus.yaml > > [...] > > > I have take a look at xilinx part of this and try to build it for arm64 > > platforms and I see errors coming from this cpu description. > > /root/linux/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml: > > cpu@0:compatible: ['arm,cortex-a53', 'arm,armv8'] is too long > > /root/linux/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml: > > cpu@0:compatible: Additional items are not allowed ('arm,armv8' was > > unexpected) > > Thanks for actually giving this a spin! > > > Based on grep this is used in a lot of places > > compatible = "arm,cortex-a53", "arm,armv8"; > > > > Should this be moved to just simple? > > compatible = "arm,cortex-a53"; > > I'd normally go with the majority which would be to keep it. However, > 'arm,armv8' is of questionable value, isn't actually documented, and > doesn't exist for any other version of the architecture. So we should > kill it IMO. I'd prefer to keep it around, since that's what's used to describe the CPUs on the fastmodel iirc. Will