Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265526AbUAPOHh (ORCPT ); Fri, 16 Jan 2004 09:07:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265533AbUAPOHh (ORCPT ); Fri, 16 Jan 2004 09:07:37 -0500 Received: from phoenix.infradead.org ([213.86.99.234]:18948 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S265526AbUAPOHf (ORCPT ); Fri, 16 Jan 2004 09:07:35 -0500 Date: Fri, 16 Jan 2004 14:07:28 +0000 From: Christoph Hellwig To: Pavel Machek Cc: "Amit S. Kale" , kgdb-bugreport@lists.sourceforge.net, kernel list Subject: Re: KGDB 2.0.3 with fixes and development in ethernet interface Message-ID: <20040116140728.B24102@infradead.org> Mail-Followup-To: Christoph Hellwig , Pavel Machek , "Amit S. Kale" , kgdb-bugreport@lists.sourceforge.net, kernel list References: <200401161759.59098.amitkale@emsyssoft.com> <20040116125806.GA7409@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040116125806.GA7409@elf.ucw.cz>; from pavel@ucw.cz on Fri, Jan 16, 2004 at 01:58:06PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 22 On Fri, Jan 16, 2004 at 01:58:06PM +0100, Pavel Machek wrote: > ++int kgdbeth_thread(void *data) > ++{ > ++ struct net_device *ndev = (struct net_device *)data; > ++ daemonize("kgdbeth"); > ++ while (!ndev->ip_ptr) { > ++ schedule(); > ++ } > ++ debugger_entry(); > ++ return 0; > > Don't you need some locking around ndev->ip_ptr? [Okay, it probably > only matters on SMP, so it is not causing your problems..] Not to mention it should use a proper wait_event instead of this really stupid loop. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/