Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 3 Dec 2018 15:47:38 +0100
From:   Marek Marczykowski <marmarek@invisiblethingslab.com>
To:     Jan Beulich <JBeulich@suse.com>
Cc:     Dwayne Litzenberger <dlitz@dlitz.net>,
        Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 2/2] xen-pciback: Allow enabling/disabling
 expansion ROM
Message-ID: <20181203144738.GQ781@mail-itl>
References: <cover.55c0e31b75e2fbdf4206cc39c2fd7581793ae7ae.1543772656.git-series.marmarek@invisiblethingslab.com>
 <cover.55c0e31b75e2fbdf4206cc39c2fd7581793ae7ae.1543772656.git-series.marmarek@invisiblethingslab.com>
 <a05e3cf451d692dc4b1c81c8b5d66fc75d1fa325.1543772656.git-series.marmarek@invisiblethingslab.com>
 <5C050CF3020000780020223F@prv1-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="YPYi+6JBnn8IjLOH"
Content-Disposition: inline
In-Reply-To: <5C050CF3020000780020223F@prv1-mh.provo.novell.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--YPYi+6JBnn8IjLOH
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 03, 2018 at 04:01:07AM -0700, Jan Beulich wrote:
> >>> On 02.12.18 at 18:47, <marmarek@invisiblethingslab.com> wrote:
> > From: Dwayne Litzenberger <dlitz@dlitz.net>
> >=20
> > Newer AMD GPUs store their initialization routines as bytecode on the
> > ROM.  This fixes the following initialization error inside the VM when
> > doing PCI passthrough:
> >=20
> >     radeon 0000:00:05.0: Invalid PCI ROM header signature: expecting 0x=
aa55, got 0xffff
> >     radeon 0000:00:05.0: Invalid PCI ROM header signature: expecting 0x=
aa55, got 0xffff
> >     [drm:radeon_get_bios [radeon]] *ERROR* Unable to locate a BIOS ROM
> >     radeon 0000:00:05.0: Fatal error during GPU init
>=20
> Isn't it that qemu is supposed to surface the ROM image to guests,
> making it unnecessary to allow guests control over the physical
> enable bit?=20

Unless that qemu is in stubdomain, where it use pciback to access
everything about the device...

> Also why would allowing to alter the bit depend on
> whether the address portion of the value is non-zero?

That's a good question. According to commit message I think it should be
a ROM presence check instead. If needed at this point at all - is this
function even called if there is no ROM?

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

--YPYi+6JBnn8IjLOH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlwFQgoACgkQ24/THMrX
1yzHOwgAlmyX8AwWoWYIW87CGtuTbVpBXQmaYjhCULHvRQaHsxW2b2xeviyuAScY
cC3TKViZwgtFEHkH/mODR96Dn0KDxabDMxIym/FAXu179KS5lPpFZQhNo1oDNaL6
072FLHQ1xOXxqHVUp4AQOc9gBnXmFGXBG+WXqOyCT0/PiJDeymucnsQuu1jdVRgb
5pU2gsB8bYbyy6ZXfpbLLm/mQR8i6k8SR0TBmNHK5H43SR4eUDDPZQqOCwyWTBUn
hMfSw2zUyNJllugBbclxxXEFZM+Vq8ZAiriqND/xLWl4wrlpqT654E2aymSD6qTU
djuJIkiQ15nhaZe7UecjCpyRyegojA==
=IdtU
-----END PGP SIGNATURE-----

--YPYi+6JBnn8IjLOH--