Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7041862imu; Mon, 3 Dec 2018 06:55:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/XLSlGArqyzdvwtVMJl6/wcvqvChGMvKwUI2YsA8mLxJf2lXENP+lrpDMXw3UtKkERFTqhD X-Received: by 2002:a63:ea15:: with SMTP id c21mr12775921pgi.361.1543848903682; Mon, 03 Dec 2018 06:55:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543848903; cv=none; d=google.com; s=arc-20160816; b=uEwDYY/4ibKHGG0tUFKxsamv3XEYYqFUM1btuIGEk+jRpNZxyAJRXKV/zvKUZEIl4T unRuzxqJLCUNQkmPWt1TBehiyNwc6I379AjXMvm7/RBdb3oviTeEGAUQDhZOsgpMP6k6 bav3a+KDbf+XeRIx3JidbhaVSTXsUNayicXUJ3aC/PNwWr/acTkm3qHYtUjP0inj93de OHqcYAGhRkkkEUvvaC4+VZHoGlUGgsqIQ8mlffKfWwMKm6/5QMBqxCs8Eaq04is3Sv5U pVOI7KAh+MVYE/rK1WqcvTI0gP+ai+15Pism9ceLaqm90U9spxa0iIm3M11CRDVpO6Rn DVew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=mLL/RzBXmbn6MdDQ4TBUMgjRnL/4U0BtjoyoEh8gszY=; b=asTrbvZ6NRLkYrKwjKPdxWymZMfwLJ+DTnKgdsM2FvGo/rwSoorHMkvFpPXxqCCbfg 2fmXI71WQL3XCflTZOSTPlKYDDrUA0H4EBhKFzMW2jamEPD3vDuOtHrWbL3LH8E8F/HC C47fdeoRaHHpwdDyz+PoBrAxKduzskiMksIK9qLiK5Cz6H+q5D4fHJgk9hUkNFCs8Qol iL7LIEK1e1dBY1KSBf8CgFqpcY7oTrn1qVkxChwsj21BJtDLu2ghAJIBmlDeRcG6ZKCX m8Py71Wy66+UIuHyVZCmA6cDBioRgpoUBTQLEJI1b28G2Lp+bdtCZ/EaeMjh3o9uyf+y B/2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NK+dcPpI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si12291917pgj.373.2018.12.03.06.54.48; Mon, 03 Dec 2018 06:55:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NK+dcPpI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbeLCOzO (ORCPT + 99 others); Mon, 3 Dec 2018 09:55:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:37234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbeLCOzN (ORCPT ); Mon, 3 Dec 2018 09:55:13 -0500 Received: from [192.168.1.75] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DE812082F; Mon, 3 Dec 2018 14:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543848835; bh=7QLRPFUy76EzZq8m+d6qy6CP2Pv2mnEya/rkHsisPc8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NK+dcPpI6Z+Y9CzoXVNnXXNSH1REYIObMbDq3UY9A1a5n9qjmss0AiF/boFbBFNOO rkdYf//teIzyFemSGSOlzFVUgE/3iwm8sLnvHNt+gznU80Qr1yKMIhxzubYZK1+QSI G+milisorWfSe1jN86GPnGwAv7PhIj7RSe/lQWCM= Subject: Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap To: Wen Yang , Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn References: <20181203064317.57054-1-wen.yang99@zte.com.cn> From: Timur Tabi Message-ID: Date: Mon, 3 Dec 2018 08:53:53 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181203064317.57054-1-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/3/18 12:43 AM, Wen Yang wrote: > The null check on &info->cmap is redundant since cmap is a struct > inside fb_info and can never be null, so the check is always true. > we may remove it. > > Signed-off-by: Wen Yang Acked-by: Timur Tabi