Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7146675imu; Mon, 3 Dec 2018 08:23:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/VVTLh2uqbLDNGZOIhUjrR9ZDVMt8wuVri4o8Gx7VSDtS/+b8otP99wBesu7vx9+vbNGUjl X-Received: by 2002:a17:902:690c:: with SMTP id j12mr16411687plk.206.1543854199789; Mon, 03 Dec 2018 08:23:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543854199; cv=none; d=google.com; s=arc-20160816; b=KcYvfO50Ta8YJtWa5ptTm/3/HprVI9UYN7OGK6jpbKT7xpHf1ov8RvhiJ2bq0tGVGl StyFQNm9KeUJZTf54F0weo/eCFU1vFBY+chkQMcvH0/Z+jeGVpqKXTjwaN1UzMis3Igb x0zuBhNx9m0+HSmbrGJYxydNGCFK5NWzh0lxCpdV5ymMesVwp74DqnZ7aZU+w9OCMM33 TReJVJxACKXOsPQagiQtTmkAW5MRiw7f0qCqStHo54YO03Jbkz6mn6gesWF/tVzSGPA7 nTorQi73MR7nTBipahhTsPtVPR/LJ2JKejF1qrIsktVl/pQL7N0bTMZumei4NhivJwIi wRcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature; bh=1+jSbq/mwZcXtkckcWnWIXiikFvnkPIT0r9z07orVow=; b=u+ugE0HKxvqkQIelew66dyo/wgrRLuH8xmXJBFVZbz6DUIbd3WvLmn1qxYwbWIOSy0 OiVJhR8HwoSNC6Z2nd4YXFztdhSfn5N+124PBrjJGn4039Ynn8+1R7qGAjhv35IjkHoB 2Axh3v3PX2qXVCo6sZQWagpa9T2ST8veSk5gFzCQNAKR+s0N5t0EeowUX33VVkcDUytb uGzTxVq0LfDOO+w2sPhHrnj2tomBey4ahdT0cqK3r3UjZXrsaJ9bxvf0ZMKc+EYFCgnx SVcaiqRYoHwHV4JqjHIX8DUAld7oLD0r31l+lw6fi7iWouXRn4F5qpXO4UYuM41/cf0g Tpmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NSboZuQo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si13157601pgh.18.2018.12.03.08.22.53; Mon, 03 Dec 2018 08:23:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NSboZuQo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbeLCQW0 (ORCPT + 99 others); Mon, 3 Dec 2018 11:22:26 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45339 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbeLCQW0 (ORCPT ); Mon, 3 Dec 2018 11:22:26 -0500 Received: by mail-pf1-f195.google.com with SMTP id g62so6600075pfd.12 for ; Mon, 03 Dec 2018 08:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:to:from:in-reply-to:cc :references:message-id:user-agent:subject:date; bh=1+jSbq/mwZcXtkckcWnWIXiikFvnkPIT0r9z07orVow=; b=NSboZuQouyFHAx2W1YN8eXO/p4qL2quUKsDFGsDptHBbS6miDxXwwPjJNqvsN+IPs3 nDZE8/I8BcE4ETVyK/USDsJGCbOZ5IVOq6EUps3Iss9w6UnEcBf4U8iiOT34xsiiPEvk UycXMWk9+KetWYXcgyCJQmlGKK0tvbnMw792E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date; bh=1+jSbq/mwZcXtkckcWnWIXiikFvnkPIT0r9z07orVow=; b=hw8THQXrWxIObWxKksfWl+V8FzQu84xDyHtUfFNlHxeyzHV9Y71TuC1juuW0awJnNT 402tUdbjgUWVq4jWvyxF16vSgnbOhwn719iRfBmQmCjpaLhyjEbx9y0VYj76Xw8sgApB ihDMn3V1f6BzzO2UGPF8FLUp59ZVZWZkOavIdzY6u+C/QxWSAolpIXdqlHobhsxsqZGV Ob46eT9HjDOM+ecxgu7+vf5laknswXW/15cn2y6scQM3FMxpYMlRqWAgQEPEl9jElJxn FEmHS0yQL0nXp9ZrwPwAp+TpJNfeIPOwBwBvif9/zBWiDqHEDqxpCdmU5G6mZCOMGY+d gA2g== X-Gm-Message-State: AA+aEWbVIH2WKTwtNsvT94OLmOXgXLzGJIhMjs/MZf3nK/gLiyZgi74h 6471Gbz9MrHh0utbFbUzKVFLpw== X-Received: by 2002:a62:15c3:: with SMTP id 186mr17101128pfv.240.1543854137703; Mon, 03 Dec 2018 08:22:17 -0800 (PST) Received: from localhost ([2620:15c:202:1:fed3:9637:a13a:6c15]) by smtp.gmail.com with ESMTPSA id 134sm16030678pgb.78.2018.12.03.08.22.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Dec 2018 08:22:16 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Greg Kroah-Hartman , Jiri Slaby , Ryan Case From: Stephen Boyd In-Reply-To: <20181130021840.75861-1-ryandcase@chromium.org> Cc: Evan Green , Doug Anderson , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Ryan Case References: <20181130021840.75861-1-ryandcase@chromium.org> Message-ID: <154385413596.88331.2252934244242692154@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v3] tty: serial: qcom_geni_serial: Fix softlock Date: Mon, 03 Dec 2018 08:22:15 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ryan Case (2018-11-29 18:18:40) > Transfers were being divided into device FIFO sized (64 byte max) > operations which would poll for completion within a spin_lock_irqsave / > spin_unlock_irqrestore block. This both made things slow by waiting for > the FIFO to completely drain before adding further data and would also > result in softlocks on large transmissions. > = > This patch allows larger transfers with continuous FIFO additions as > space becomes available and removes polling from the interrupt handler. > = > Signed-off-by: Ryan Case > --- Reviewed-by: Stephen Boyd