Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181201005759.28093-1-eric@anholt.net> <20181201005759.28093-6-eric@anholt.net>
In-Reply-To: <20181201005759.28093-6-eric@anholt.net>
From:   Dave Emett <david.emett@broadcom.com>
Date:   Mon, 3 Dec 2018 18:03:05 +0000
Message-ID: <CAApk1dU5MrxN4XMCkUjaGpNDzrT1pGuRRphpfoF602=7y4FnMg@mail.gmail.com>
Subject: Re: [PATCH 6/6] drm/v3d: Add missing fence timeline name for TFU.
To:     Eric Anholt <eric@anholt.net>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Thomas Spurden <thomas.spurden@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 1 Dec 2018 at 00:58, Eric Anholt <eric@anholt.net> wrote:
>
> We shouldn't be returning v3d-render in for our new queue.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Dave Emett <david.emett@broadcom.com>

> Fixes: 83d5139982db ("drm/v3d: Add support for submitting jobs to the TFU.")
> ---
>  drivers/gpu/drm/v3d/v3d_fence.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_fence.c b/drivers/gpu/drm/v3d/v3d_fence.c
> index 50bfcf9a8a1a..b0a2a1ae2eb1 100644
> --- a/drivers/gpu/drm/v3d/v3d_fence.c
> +++ b/drivers/gpu/drm/v3d/v3d_fence.c
> @@ -29,10 +29,16 @@ static const char *v3d_fence_get_timeline_name(struct dma_fence *fence)
>  {
>         struct v3d_fence *f = to_v3d_fence(fence);
>
> -       if (f->queue == V3D_BIN)
> +       switch (f->queue) {
> +       case V3D_BIN:
>                 return "v3d-bin";
> -       else
> +       case V3D_RENDER:
>                 return "v3d-render";
> +       case V3D_TFU:
> +               return "v3d-tfu";
> +       default:
> +               return NULL;
> +       }
>  }
>
>  const struct dma_fence_ops v3d_fence_ops = {
> --
> 2.20.0.rc1
>