Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7307858imu; Mon, 3 Dec 2018 10:44:09 -0800 (PST) X-Google-Smtp-Source: AFSGD/XlUydIN09B8/JGUetURznidjO2JEaCYGIQyhTMxOBPCK+ePMzEzeFBoFnW7JeBa2YFX0Ny X-Received: by 2002:a62:65c5:: with SMTP id z188mr12683184pfb.64.1543862649461; Mon, 03 Dec 2018 10:44:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543862649; cv=none; d=google.com; s=arc-20160816; b=CiMw+gP7AFu9ZsB8+uQI5nGXExKOzriLDLMZVRsrFovlbXEEDdu/QrID4YGBXmMBo2 5KXXHiQs5z8RiYwcU3kuXV4OP9lZVOecaUTyug19+rei+A95pqO5jVbPg5g++LQuNH93 eSf2KKT4hVn5yjyT9bevTWuby/iBa9/z1FzKd0aEpNw1oR+eVd/WCEytae2inBmMoctJ UbAK9ewjUPKADj+nkjkjBuB3UUca1z6wk/WCqQOmBJ5sOoj0jggMdtD/GrygT2N7GlZb o/8CVeLH7xDSfavy3tHTSHAfk8z0183Uu7RLtQ/raYXd3YWi/d4VsNhPA6/vNk7D5Xji dA4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=TmjpGq9zJhuwD+j+P7vEpv8lus+jnXSYmcvI59PzmNs=; b=Vlfry8l48NXqeF5xNxBikvjTcOcFDwMNJGdkP32TyosCUY3KiKtItrWDVgz6uubCjT jLNzY2mpV8Pda9YcJ0tYMWr0eovDWkBjlAUQmRd+hcLKfVQGJ86mwx//HN6A4Sl6elJ6 ewg24hqrOp5kBHO2ESVHwQz5PS0ELkMmlhJnRU4dcYAmCtiI1L9xJQiMAcdbY1dnzR81 9SHvv9NGqNS89vfrUkDl+BnUMcs7yWsbg0ak8mM1aX0bjIS0fi7Bz/SzM6dX7F7ZrQy5 UJBDfyXTm5i8ib8fHaNkz4ej4MHhxNct6ygUdGUDYsWmCqE1EDWKbkzIwWBFKyYu0n+0 qt5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si14126451pfe.74.2018.12.03.10.43.54; Mon, 03 Dec 2018 10:44:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbeLCSl6 (ORCPT + 99 others); Mon, 3 Dec 2018 13:41:58 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:59420 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbeLCSl5 (ORCPT ); Mon, 3 Dec 2018 13:41:57 -0500 X-Greylist: delayed 503 seconds by postgrey-1.27 at vger.kernel.org; Mon, 03 Dec 2018 13:41:56 EST Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 4BA242464F; Mon, 3 Dec 2018 18:33:30 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo06-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vqc-pqqJmWU1; Mon, 3 Dec 2018 18:33:30 +0000 (UTC) Received: from mail.gonehiking.org (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by mailout.easymail.ca (Postfix) with ESMTPA id 1B2F624672; Mon, 3 Dec 2018 18:33:24 +0000 (UTC) Received: from [192.168.1.4] (rhapsody.internal [192.168.1.4]) by mail.gonehiking.org (Postfix) with ESMTP id 3B3159F243; Mon, 3 Dec 2018 11:33:24 -0700 (MST) Subject: Re: [PATCH 01/41] scsi: BusLogic: mark expected switch fall-through To: "Gustavo A. R. Silva" Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Khalid Aziz Openpgp: preference=signencrypt Autocrypt: addr=khalid@gonehiking.org; prefer-encrypt=mutual; keydata= xsFNBFA5V58BEADa1EDo4fqJ3PMxVmv0ZkyezncGLKX6N7Dy16P6J0XlysqHZANmLR98yUk4 1rpAY/Sj/+dhHy4AeMWT/E+f/5vZeUc4PXN2xqOlkpANPuFjQ/0I1KI2csPdD0ZHMhsXRKeN v32eOBivxyV0ZHUzO6wLie/VZHeem2r35mRrpOBsMLVvcQpmlkIByStXGpV4uiBgUfwE9zgo OSZ6m3sQnbqE7oSGJaFdqhusrtWesH5QK5gVmsQoIrkOt3Al5MvwnTPKNX5++Hbi+SaavCrO DBoJolWd5R+H8aRpBh5B5R2XbIS8ELGJZfqV+bb1BRKeo0kvCi7G6G4X//YNsgLv7Xl0+Aiw Iu/ybxI1d4AtBE9yZlyG21q4LnO93lCMJz/XqpcyG7DtrWTVfAFaF5Xl1GT+BKPEJcI2NnYn GIXydyh7glBjI8GAZA/8aJ+Y3OCQtVxEub5gyx/6oKcM12lpbztVFnB8+S/+WLbHLxm/t8l+ Rg+Y4jCNm3zB60Vzlz8sj1NQbjqZYBtBbmpy7DzYTAbE3P7P+pmvWC2AevljxepR42hToIY0 sxPAX00K+UzTUwXb2Fxvw37ibC5wk3t7d/IC0OLV+X29vyhmuwZ0K1+oKeI34ESlyU9Nk7sy c1WJmk71XIoxJhObOiXmZIvWaOJkUM2yZ2onXtDM45YZ8kyYTwARAQABzSNLaGFsaWQgQXpp eiA8a2hhbGlkQGdvbmVoaWtpbmcub3JnPsLBegQTAQgAJAIbAwULCQgHAwUVCgkICwUWAgMB AAIeAQIXgAUCUDlYcgIZAQAKCRDNWKGxftAz+mCdD/4s/LpQAYcoZ7TwwQnZFNHNZmVQ2+li 3sht1MnFNndcCzVXHSWd/fh00z2du3ccPl51fXU4lHbiG3ZyrjX2Umx48C20Xg8gbmdUBzq4 9+s12COrgwgsLyWZAXzCMWYXOn9ijPHeSQSq1XYj8p2w4oVjMa/QfGueKiJ5a14yhCwye2AM f5o8uDLf+UNPgJIYAGJ46fT6k5OzXGVIgIGmMZCbYPhhSAvLKBfLaIFd5Bu6sPjp0tJDXJd8 pG831Kalbqxk7e08FZ76opzWF9x/ZjLPfTtr4xiVvx+f9g/5E83/A5SvgKyYHdb3Nevz0nvn MqQIVfZFPUAQfGxdWgRsFCudl6i9wEGYTcOGe00t7JPbYolLlvdn+tA+BCE5jW+4cFg3HmIf YFchQtp+AGxDXG3lwJcNwk0/x+Py3vwlZIVXbdxXqYc7raaO/+us8GSlnsO+hzC3TQE2E/Hy n45FDXgl51rV6euNcDRFUWGE0d/25oKBXGNHm+l/MRvV8mAdg3iTiy2+tAKMYmg0PykiNsjD b3P5sMtqeDxr3epMO+dO6+GYzZsWU2YplWGGzEKI8sn1CrPsJzcMJDoWUv6v3YL+YKnwSyl1 Q1Dlo+K9FeALqBE5FTDlwWPh2SSIlRtHEf8EynUqLSCjOtRhykmqAn+mzIQk+hIy6a0to9iX uLRdVc7BTQRQOVefARAAsdGTEi98RDUGFrxK5ai2R2t9XukLLRbRmwyYYx7sc7eYp7W4zbnI W6J+hKv3aQsk0C0Em4QCHf9vXOH7dGrgkfpvG6aQlTMRWnmiVY99V9jTZGwK619fpmFXgdAt WFPMeNKVGkYzyMMjGQ4YbfDcy04BSH2fEok0jx7Jjjm0U+LtSJL8fU4tWhlkKHtO1oQ9Y9HH Uie/D/90TYm1nh7TBlEn0I347zoFHw1YwRO13xcTCh4SL6XaQuggofvlim4rhwSN/I19wK3i YwAm3BTBzvJGXbauW0HiLygOvrvXiuUbyugMksKFI9DMPRbDiVgCqe0lpUVW3/0ynpFwFKeR FyDouBc2gOx8UTbcFRceOEew9eNMhzKJ2cvIDqXqIIvwEBrA+o92VkFmRG78PleBr0E8WH2/ /H/MI3yrHD4F4vTRiPwpJ1sO/JUKjOdfZonDF6Hu/Beb0U5coW6u7ENKBmaQ/nO1pHrsqZp+ 2ErG02yOHF5wDWxxgbd4jgcNTKJiY9F1cdKP+NbWW/rnJgem8qYI3a4VkIkFT5BE2eYLvZlR cIzWc/ve/RoQh6jzXD0T08whoajZ1Y3yFQ8oyLSFt8ybxF0b5XryL2RVeHQTkE8NKwoGVYTn ER+o7x2sUGbIkjHrE4Gq2cooEl9lMv6I5TEkvP1E5hiZFJWYYnrXa/cAEQEAAcLBXwQYAQgA CQUCUDlXnwIbDAAKCRDNWKGxftAz+reUEACQ+rz2AlVZZcUdMxWoiHqJTb5JnaF7RBIBt6Ia LB9triebZ7GGW+dVPnLW0ZR1X3gTaswo0pSFU9ofHkG2WKoYM8FbzSR031k2NNk/CR0lw5Bh whAUZ0w2jgF4Lr+u8u6zU7Qc2dKEIa5rpINPYDYrJpRrRvNne7sj5ZoWNp5ctl8NBory6s3b bXvQ8zlMxx42oF4ouCcWtrm0mg3Zk3SQQSVn/MIGCafk8HdwtYsHpGmNEVn0hJKvUP6lAGGS uDDmwP+Q+ThOq6b6uIDPKZzYSaa9TmL4YIUY8OTjONJ0FLOQl7DsCVY9UIHF61AKOSrdgCJm N3d5lXevKWeYa+v6U7QXxM53e1L+6h1CSABlICA09WJP0Fy7ZOTvVjlJ3ApO0Oqsi8iArScp fbUuQYfPdk/QjyIzqvzklDfeH95HXLYEq8g+u7nf9jzRgff5230YW7BW0Xa94FPLXyHSc85T E1CNnmSCtgX15U67Grz03Hp9O29Dlg2XFGr9rK46Caph3seP5dBFjvPXIEC2lmyRDFPmw4yw KQczTkg+QRkC4j/CEFXw0EkwR8tDAPW/NVnWr/KSnR/qzdA4RRuevLSK0SYSouLQr4IoxAuj nniu8LClUU5YxbF57rmw5bPlMrBNhO5arD8/b/XxLx/4jGQrcYM+VrMKALwKvPfj20mB6A== Message-ID: <0d5df4a3-c614-572b-45e6-bd29f13ed361@gonehiking.org> Date: Mon, 3 Dec 2018 11:33:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/18 9:21 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1056537 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/BusLogic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c > index 9cee941f97d6..717eef3ee893 100644 > --- a/drivers/scsi/BusLogic.c > +++ b/drivers/scsi/BusLogic.c > @@ -2641,6 +2641,7 @@ static int blogic_resultcode(struct blogic_adapter *adapter, > case BLOGIC_BAD_CMD_PARAM: > blogic_warn("BusLogic Driver Protocol Error 0x%02X\n", > adapter, adapter_status); > + /* fall through */ > case BLOGIC_DATA_UNDERRUN: > case BLOGIC_DATA_OVERRUN: > case BLOGIC_NOEXPECT_BUSFREE: > Looks good. Acked-by: Khalid Aziz