Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7492607imu; Mon, 3 Dec 2018 13:55:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vfvz7YFj6SE/rTzWtbyoK3UnJk5Qiyp0dBb7D4WRKnIoG+yr4Q//tDVCTARhrjWUyRcEo0 X-Received: by 2002:a63:4665:: with SMTP id v37mr14965571pgk.425.1543874123206; Mon, 03 Dec 2018 13:55:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543874123; cv=none; d=google.com; s=arc-20160816; b=oCGqw1gkJXjCsgaZj4/ewBBF3L54eK2T3XB8M2kGxIoBHkocAdTwpVau80ewitIaoE A1vRlGgRp7E/n1STPX4qwIgkjDsH4NC6hkhp9ZmasYQ8X2x0yXWE6pwwvgJD+8oyMF2a 4pLX0cqUWXvk0JF2th1WlQeak/CaGZVcHcO7sDjnsL0h7EuXq/WS3HfLzdotn1NOywxV Ce7sgcxN4jN1FlyMDUWdehALyG20QGKPEU0/tQgF1q0qs00gfukLOrjT7N+DgGlYWUlX UkJk3WcpsYblOMW5A1Qx2PyBqAKq5jBtDf35uCc8hhbTGTESEn4OboT5TXTFk1wcwrra OVEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kLXKSBFR64cdJRmP6GVsYGeUhFKxfDncsOWr/RjgpJs=; b=M2a0Rnu1m2TLWzeRBkynNFF75FWvSKObsNt6D/DuGMHdxiYqhiYMMG1gFH4CAj296R lHqMKqhe48izkzNVNVpGMtCLXalB9D1Dzo9DKMHEf4YNFMTr/gcwkzb77gEF19M/DZhL QcMPh+7WBcEuB6HrL3ot/R6CHt5yFtC+97CCOUWys6BYqUhW9mMTDz8mYvt7JfOJgyVd FSzFvUm/iABVzjGUj2HyJSwMulQymHnxp0+vpIg+pjPfWgCs/f3ryHDlEkPGzRN1Yqjx PHZBlg5RQGPvsl5hR1i4EZqCq6JRovOTFyDV2XAIS17Hk3SMH6xRMDwDkPBH/WDdld4p kl7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11si15060048plq.287.2018.12.03.13.55.08; Mon, 03 Dec 2018 13:55:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726159AbeLCVyC (ORCPT + 99 others); Mon, 3 Dec 2018 16:54:02 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47536 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbeLCVyA (ORCPT ); Mon, 3 Dec 2018 16:54:00 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4AD3F12107045; Mon, 3 Dec 2018 13:54:00 -0800 (PST) Date: Mon, 03 Dec 2018 13:53:59 -0800 (PST) Message-Id: <20181203.135359.135247381013242647.davem@davemloft.net> To: suyj.fnst@cn.fujitsu.com Cc: saeedm@mellanox.com, galp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: 8139cp: fix a BUG triggered by changing mtu with network traffic From: David Miller In-Reply-To: <20181203073307.14551-1-suyj.fnst@cn.fujitsu.com> References: <20181203073307.14551-1-suyj.fnst@cn.fujitsu.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Dec 2018 13:54:00 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Su Yanjun Date: Mon, 3 Dec 2018 15:33:07 +0800 > When changing mtu many times with traffic, a bug is triggered: ... > The patch will check IntrMask before check IntrStatus in cp_interrupt. > When 8139cp interrupt is disabled, just return. > > Signed-off-by: Su Yanjun Applied and queued up for -stable.