Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 03 Dec 2018 15:12:53 -0800 (PST)
Message-Id: <20181203.151253.1348214769326219632.davem@davemloft.net>
To:     jakub.kicinski@netronome.com
Cc:     salil.mehta@huawei.com, yisen.zhuang@huawei.com,
        lipeng321@huawei.com, mehta.salil@opnsrc.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, liuzhongzhu@huawei.com, jiri@resnulli.us,
        f.fainelli@gmail.com
Subject: Re: [RFC net-next 3/9] net: hns3: Add "port vlan table"
 information query function
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181203151222.6e56efcd@cakuba.netronome.com>
References: <20181202230933.15560-1-salil.mehta@huawei.com>
        <20181202230933.15560-4-salil.mehta@huawei.com>
        <20181203151222.6e56efcd@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Mon, 3 Dec 2018 15:12:22 -0800

> On Sun, 2 Dec 2018 23:09:27 +0000, Salil Mehta wrote:
>> From: liuzhongzhu <liuzhongzhu@huawei.com>
>> 
>> This patch prints port vlan table information.
>> 
>> debugfs command:
>> echo dump port vlan tbl > cmd
>> 
>> Sample Command:
>> root@(none)# echo dump port vlan tbl > cmd
>>  vlan | port filter bitMap:
>>  0000 | 00000000:00000000:00000000:00000000:00000000:00000001
>> root@(none)#
>> 
>> Signed-off-by: liuzhongzhu <liuzhongzhu@huawei.com>
>> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> 
> Adding debugfs files for basic switch concepts like MAC and VLAN tables
> seems like a bit of a stretch to me.  I wonder what others think.

Agreed.