Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 03 Dec 2018 16:15:14 -0800 (PST)
Message-Id: <20181203.161514.1229179839092578403.davem@davemloft.net>
To:     cai@gmx.us
Cc:     yisen.zhuang@huawei.com, salil.mehta@huawei.com, joe@perches.com,
        stephen@networkplumber.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/core: tidy up an error message
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181202021119.7737-1-cai@gmx.us>
References: <20181202021119.7737-1-cai@gmx.us>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Qian Cai <cai@gmx.us>
Date: Sat,  1 Dec 2018 21:11:19 -0500

> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
> 
> "netif_napi_add() called with weight 256 on device eth%d"
> 
> For example, hns_enet_drv module does this.
> 
> hns_nic_try_get_ae
>   hns_nic_init_ring_data
>     netif_napi_add
>   register_netdev
>     dev_get_valid_name
> 
> Hence, make it a bit more human-readable by using netdev_err_once()
> instead.
> 
> Signed-off-by: Qian Cai <cai@gmx.us>

Applied, thanks.