Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH linux-next v2 0/6] clk: renesas: adg: add AVB Clock
To:     Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
        <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <kuninori.morimoto.gx@renesas.com>
CC:     <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20181203112200.18220-1-jiada_wang@mentor.com>
 <d63c751b-fab4-cf88-459e-efe5a3e83da4@mentor.com>
From:   Jiada Wang <jiada_wang@mentor.com>
Message-ID: <fb9fee84-7508-03dc-c1e7-30de3d2ee958@mentor.com>
Date:   Tue, 4 Dec 2018 17:24:23 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <d63c751b-fab4-cf88-459e-efe5a3e83da4@mentor.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vladimir

Thanks for your comments

On 2018/12/03 21:11, Vladimir Zapolskiy wrote:
> Hi Jiada,
>
> On 12/03/2018 01:21 PM, jiada_wang@mentor.com wrote:
>> From: Jiada Wang <jiada_wang@mentor.com>
>>
>> on R-Car SoCs there are AVB Counter Clocks, each clock has 12bits integral
>> and 8 bits fractional dividers which operates with S0D1ϕ clock.
>>
>> This patch-set adds 'adg' clock to R-Car Soc, and changes adg driver to
>> register avb clocks when clock-cells of rcar_sound node is 2.
>>
>> ---
>> v2:
>> - expends adg register size and register avb clocks instead of
>>    add new clk-avb driver
>> - Add adg clock
>>
>> v1: initial version
>>
>> Jiada Wang (2):
>>    dt-bindings: clock: add clock id for renesas adg clocks
>>    ASoC: rsnd: add avb clocks
>>
>> Takeshi Kihara (4):
>>    clk: renesas: r8a7795: Add ADG clock
>>    clk: renesas: r8a7796: Add ADG clock
>>    clk: renesas: r8a77990: Add ADG clocks
>>    clk: renesas: r8a77995: Add ADG clock
>>
> plural 'clocks' for r8a77990 vs. 'clock' in other cases, please unify subjects.
>
> You can consider to add the ADG clock description for r8a77965 / M3-N as well.
will unify the subjects and add ADG clock to r8a77965 in next version
>>   drivers/clk/renesas/r8a7795-cpg-mssr.c  |   1 +
>>   drivers/clk/renesas/r8a7796-cpg-mssr.c  |   1 +
>>   drivers/clk/renesas/r8a77990-cpg-mssr.c |   1 +
>>   drivers/clk/renesas/r8a77995-cpg-mssr.c |   1 +
>>   include/dt-bindings/clock/renesas-adg.h |  11 +
> The new header file added above is not needed in my opinion.
>
>>   sound/soc/sh/rcar/adg.c                 | 306 +++++++++++++++++++++++-
>>   sound/soc/sh/rcar/gen.c                 |   9 +
>>   sound/soc/sh/rcar/rsnd.h                |   9 +
>>   8 files changed, 330 insertions(+), 9 deletions(-)
>>   create mode 100644 include/dt-bindings/clock/renesas-adg.h
>>
> --
> Best wishes,
> Vladimir