Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Christophe LEROY <christophe.leroy@c-s.fr>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, npiggin@gmail.com,
        rashmicy@gmail.com
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: dump block address translation on book3s/32
In-Reply-To: <bab9eb25-a6f4-966c-ceaa-00147b50726d@c-s.fr>
References: <26cc609706833f78e3195e3d35c0372b2f40cae3.1542181167.git.christophe.leroy@c-s.fr> <878t1uva0q.fsf@concordia.ellerman.id.au> <9cb14c1f-02ce-a2a5-94e6-95afb4d3e168@c-s.fr> <87o9ap2uif.fsf@concordia.ellerman.id.au> <bab9eb25-a6f4-966c-ceaa-00147b50726d@c-s.fr>
Date:   Tue, 04 Dec 2018 19:55:34 +1100
Message-ID: <87zhtlhdrt.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christophe LEROY <christophe.leroy@c-s.fr> writes:

> Le 16/11/2018 à 11:20, Michael Ellerman a écrit :
>> Christophe LEROY <christophe.leroy@c-s.fr> writes:
>> 
>>> Le 15/11/2018 à 12:46, Michael Ellerman a écrit :
>>>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>>>
>>>>> This patch adds a debugfs file to dump block address translation:
>>>>>
>>>>> ~# cat /sys/kernel/debug/block_address_translation
>>>>
>>>> My instinct is it should be in /sys/kernel/debug/powerpc. But I guess
>>>> the other page table dump files are not.
>>>
>>> Lol.
>>>
>>> Looks like we have the same instinct ...
>>>
>>> But you rejected my patch https://patchwork.ozlabs.org/patch/750426/ :)
>> 
>> Haha. My argument was that the kernel page table dump is not powerpc
>> specific, but this file *is* powerpc specific. Though I guess it's in
>> the same are as the page table / hash table dump, so it may as well live
>> next to them.
>
> I see you took the first version in next-test. It doesn't handle the 
> case of 64bits phys addresses. v3 does.
>
> I just sent v4 which does to v3 the changes you did (__init and powerpc/ 
> subdir)

Thanks, have picked up v4.

cheers