Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <723e6e0b-9469-4b11-9571-a65ef4f830f0@default>
Date:   Tue, 4 Dec 2018 09:21:11 +0000 (UTC)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     <tglx@linutronix.de>, <mingo@kernel.org>, <fweisbec@gmail.com>
Cc:     <srinivas.eeda@oracle.com>, <joe.jin@oracle.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tick/broadcast: Remove redundant code in
 tick_check_new_device()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Maintainers,

When cleanup my mailbox for free space, I see this patch is missed in upstr=
eam.
Checked code again, I think that code indeed could be removed safely.

So could anyone Ack or NAK it? Thanks very much.

Regards
Zhenzhong

----- zhenzhong.duan@oracle.com wrote:

> There is no way a timer used as broadcast clockevent device is also
> used as
> percpu tick clockevent device currently.
>=20
> -v2: remove meaningless description suggested by tglx
>=20
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> ---
>  kernel/time/tick-common.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>=20
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 49edc1c..9bcc866 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -320,13 +320,8 @@ void tick_check_new_device(struct
> clock_event_device *newdev)
> =20
>  =09/*
>  =09 * Replace the eventually existing device by the new
> -=09 * device. If the current device is the broadcast device, do
> -=09 * not give it back to the clockevents layer !
> +=09 * device.
>  =09 */
> -=09if (tick_is_broadcast_device(curdev)) {
> -=09=09clockevents_shutdown(curdev);
> -=09=09curdev =3D NULL;
> -=09}
>  =09clockevents_exchange_device(curdev, newdev);
>  =09tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
>  =09if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
> --=20
> 1.7.3