Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 4 Dec 2018 10:33:10 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Michal Hocko <mhocko@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Oleg Nesterov <oleg@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Chanho Min <chanho.min@lge.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux
 4.20-rc4)
Message-ID: <20181204093310.GE73770@gmail.com>
References: <20181203074700.GA21240@gmail.com>
 <20181203083942.GF31738@dhcp22.suse.cz>
 <20181203123149.GB31795@redhat.com>
 <20181203123857.GS31738@dhcp22.suse.cz>
 <20181203131006.GA10054@amd>
 <20181203135351.GU31738@dhcp22.suse.cz>
 <20181203141459.GA14789@amd>
 <20181203141737.GY31738@dhcp22.suse.cz>
 <20181204090228.GC73770@gmail.com>
 <20181204091020.GD1286@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181204091020.GD1286@dhcp22.suse.cz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Michal Hocko <mhocko@kernel.org> wrote:

> I dunno. I do not use hibernation. I am a heavy user of the suspend 
> though. I s2ram all the time. And I have certainly experienced cases 
> where suspend has failed and I onlyi found out later when I've picked 
> up my laptop from my heat up bag. Nothing fatal has resulted from that 
> but this is certainly annoying.

Hm, so I (mistakenly) thought freezing was mostly limited to hibernation 
and to a few weird cases when in flight DMA must not be suspended - but 
I'm wrong and in practice we always freeze tasks during s2ram, right?

And indeed:

 config SUSPEND_FREEZER
        bool "Enable freezer for suspend to RAM/standby" \
                if ARCH_WANTS_FREEZER_CONTROL || BROKEN
        depends on SUSPEND
        default y

which is essentially always enabled on x86.

TIL ...

s2ram is obviously a huge deal.

Just a newbie question: any chance to not do any freezing at all on 
modern laptops when doing s2ram, or at least only warn if it fails and 
try to suspend?

Because in practice losing power due to failed freezing *will* result in 
data loss, in about 90% of the time ...

So I don't even know what we are trying to protect against by refusing to 
freeze - avoiding a 0.001% data loss risk against a 90% data loss risk?

Thanks,

	Ingo