Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8104036imu; Tue, 4 Dec 2018 03:04:38 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xq6HaTzqjOnZIcL1mNlBtVmLpgHPvFW/CDAaKo4qjoYhFLh5z49s0DbRQUMjs3tYv4QE0k X-Received: by 2002:a17:902:c85:: with SMTP id 5mr19875337plt.339.1543921478244; Tue, 04 Dec 2018 03:04:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543921478; cv=none; d=google.com; s=arc-20160816; b=sIa50tE/y+1ZD+WKd5gl5Z9RPmX/EpYIFG9ZQRbNsQQjDEhfkmonaxe4BxTnILULwx lLG6Dr3l5pq8h0NJaIcq9JFGiO79QuVS75gRVkAoXUbK/dqHXm2AEOB4EaMu+8KevCOh dMd3JasjNjnl13n+iBnfx8sHWkhY9d9leLWH23/o5kX12r5IxJw8d4IrPvW+zJ2f7y4j yda/gyITAnKDz6/m5chSGqy0t/+aoesIpQCvGhbz0GRtq+kNAc2GQVpU+YVEmuloFasd FzbNI5DRE+XIt75j8e99ZP4geFpcym7KU01X/Atha9ZxfqZD9I3Jkrg7dlu4jMY2CI/t zezA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=h+/p/14RtBXsHHSo7351//X3gEfa3SoUcBDJ1Pdz9OI=; b=UpWNSTDYeQPo4EI6Nu8ZUme1tWKULv1nR9IBmXj9vE89b1DEJnuDIHCV9FEx9b3k7Z BeqkI8TeoFpbV/cNC1QAcS0+1Wu7hNjFCPQwP+w9/UzAavs9SwwUKn4vLiKcwkRcpDwj T88JRsumnXUdkkBufzG7zu8r+GuHwzsNdsmgrpkZB9U7e+taIFwI34PT6c/Ebe/8GBQc X3WvpwdaXu5W4HTE7ObyZ9ndqk7Amdo+bR7dCGXW23Qp1xillJoNWcK/soFgg7la0fVW MSMsSvVh6aHNrgD9QQRwjmVw9aWp79h/+zRVLNHpt1q0NXPEK0ZyaEZfpeh0G7k50rt0 xTfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pWyp5oGL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m76si16702373pfj.48.2018.12.04.03.04.22; Tue, 04 Dec 2018 03:04:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pWyp5oGL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727750AbeLDLDG (ORCPT + 99 others); Tue, 4 Dec 2018 06:03:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:49362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbeLDLDF (ORCPT ); Tue, 4 Dec 2018 06:03:05 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6668D2146D; Tue, 4 Dec 2018 11:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543921384; bh=SMsU7mcoDOT7t9nSiZKmXh6zRFpInWLFTs4/Gr9/rKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pWyp5oGLkAgFeXfH/RVwJAjxu45XVw9GoeJ2gjtbS/PcCIJCSQKq7KY5f5xWej27l GrpUS2P84Pf8/br8os7bqa2UrWpAXAm05pZ44tc2g4wFImPbwqlmz0RZurrxa1RFWK JLbxlnE4Xu+DHDo9QEP10XUQ2GgOJulz9SvNx5gw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaegeuk Kim , Chao Yu , Ben Hutchings , Sasha Levin Subject: [PATCH 4.14 050/146] f2fs: Add sanity_check_inode() function Date: Tue, 4 Dec 2018 11:48:56 +0100 Message-Id: <20181204103728.863000922@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181204103726.750894136@linuxfoundation.org> References: <20181204103726.750894136@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ This was done as part of commit 5d64600d4f33 "f2fs: avoid bug_on on corrupted inode" upstream, but the specific check that commit added is not applicable to 4.14. Cc: Jaegeuk Kim Cc: Chao Yu Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin --- fs/f2fs/inode.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index b1c0eb433841..917a6c3d5649 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -180,6 +180,13 @@ void f2fs_inode_chksum_set(struct f2fs_sb_info *sbi, struct page *page) ri->i_inode_checksum = cpu_to_le32(f2fs_inode_chksum(sbi, page)); } +static bool sanity_check_inode(struct inode *inode) +{ + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); + + return true; +} + static int do_read_inode(struct inode *inode) { struct f2fs_sb_info *sbi = F2FS_I_SB(inode); @@ -281,6 +288,10 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) ret = do_read_inode(inode); if (ret) goto bad_inode; + if (!sanity_check_inode(inode)) { + ret = -EINVAL; + goto bad_inode; + } make_now: if (ino == F2FS_NODE_INO(sbi)) { inode->i_mapping->a_ops = &f2fs_node_aops; -- 2.17.1