Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8110716imu; Tue, 4 Dec 2018 03:11:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/V/GbLExZRe4KSqk08C7w4OjxqwCWn0kuKvFqepZqtDLlCpjetHiH2yIgbgJgwICcjVbx/n X-Received: by 2002:a17:902:47aa:: with SMTP id r39mr19498336pld.219.1543921862039; Tue, 04 Dec 2018 03:11:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543921862; cv=none; d=google.com; s=arc-20160816; b=s3gDkhLgMRugBmOsNyh3T2ySlP1jcBdU8EQvZ3PYnUa8lMp6AEtDq8ChYWvUnbZhaz Mpof00F2EnxEUX1CzVC+D+yquL4k/5dogPpo1Hc8wETon7L2TM9PZHeHlFYis3P0xf89 giKUM/5Y1ShOEjcddNrjomqvn34KXwrUHxkZie4lTEmX2cn7FN1mXvWrC2IQcedEC5Z3 9zL26CdwjQ+uqs8i1tx0ed/zs60qWF2aud5GhDfREvc+dCHJs7etwKfYNd9mVtGMTiM9 STwi3hEPp47D3JcuOlI4I1PGTw3Eu5ISRjd1djsvVswr+Ik/ua8dp9qDzcUwfB2OJN3L lBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=41w6EbSfgfekhBrwyh7igiwuBp1/kzOPB8pOFF+6uPs=; b=cggtIBCt6/Oh87uZdZfYiKPsawXGgruM4Ba9qQLlOu7LfZCaNGMBZLUkDHmy4ZsKrF YrsVD6J8RgPiM9sRPNUiluUo2ldU2wHQDM1QLyfvo1WbO4Rov7sUiEIeRUNwJesL1G4W 9nXt2pveVaYkAW5RVT4zoGOzZRwBJBuKjLdxku2vXn3cjEqey/kPZd7VY68jTdBI9p9G wWd0BvrRHBtLeJJ51hucyoFJWNQI1XD70cFX3MhOfNJhT6SMK/kehrnlfF+WOBSEU3pc 5B3TFItS40IigzPHEqHtTwffX4tKmIvPKiBp8ksEz/EtzjRmqQvZsAe5BqlQi7qw5tda AC5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qOs3eJxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si15767890pgm.154.2018.12.04.03.10.47; Tue, 04 Dec 2018 03:11:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qOs3eJxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728050AbeLDLKK (ORCPT + 99 others); Tue, 4 Dec 2018 06:10:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:59672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728835AbeLDLJq (ORCPT ); Tue, 4 Dec 2018 06:09:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C49C2082D; Tue, 4 Dec 2018 11:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543921785; bh=QBvMVvZrpB85GkgsTNxgdbQ0qEDWT69jMzDWAiSvSdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qOs3eJxVDxlL/acC8TowJMZgwcO+njUKr9m78SF/5VUE9vhQnYmww+iKlaBaLwz/w 1Uo7Mzl9SplPAjzQmyg2BENOzadyOOmyn+aLlqDQYDtpowyDgfHoq32Z5/X3q+rfEi Wu32vvmbbM3NsOH4FntWFaDvBS37w5RgFxnYk+oI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felipe Balbi Subject: [PATCH 4.9 38/50] Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid" Date: Tue, 4 Dec 2018 11:50:33 +0100 Message-Id: <20181204103716.410608794@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181204103714.485546262@linuxfoundation.org> References: <20181204103714.485546262@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felipe Balbi commit 38317f5c0f2faae5110854f36edad810f841d62f upstream. This reverts commit ffb80fc672c3a7b6afd0cefcb1524fb99917b2f3. Turns out that commit is wrong. Host controllers are allowed to use Clear Feature HALT as means to sync data toggle between host and periperal. Cc: Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 5 ----- 1 file changed, 5 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1280,9 +1280,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc unsigned transfer_in_flight; unsigned started; - if (dep->flags & DWC3_EP_STALL) - return 0; - if (dep->number > 1) trb = dwc3_ep_prev_trb(dep, dep->trb_enqueue); else @@ -1307,8 +1304,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc else dep->flags |= DWC3_EP_STALL; } else { - if (!(dep->flags & DWC3_EP_STALL)) - return 0; ret = dwc3_send_clear_stall_ep_cmd(dep); if (ret)