Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8113890imu; Tue, 4 Dec 2018 03:14:22 -0800 (PST) X-Google-Smtp-Source: AFSGD/WEXk+P/TliITQl1H9cTuDELqQUMs7zuTMOXeZ/pihDTO7DEQqEG7bMq09KYITACt7l9HNe X-Received: by 2002:a17:902:3283:: with SMTP id z3mr19979369plb.76.1543922061954; Tue, 04 Dec 2018 03:14:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543922061; cv=none; d=google.com; s=arc-20160816; b=GEHwfpUhmtc9JGuZ0pS3na5OeJ0W3ZfwlEL1j81xzMj0ipbGdqQ8Oa6Ue4c0fCMvup fQkHlqUPznxFYybvXjj6P6jriLw68xlY2KbF3gqNzmX5u7DuxpmNqdjc+eFtCaLSZ4xp KEgCQ/F/HZxe+zfe8GXVNeaHHK2RL2DE9OzrplTuL9kMNPttjG+Sme079XpSvWB/Q8RF fLYVQX1sEm4zjUEBAmSLM2B5fzUqOk3lcURPn87hDqsHV/N36M2ZH5oex98kDj9vpHDS 3wvML4KPSCy9O/I5zy4uhNXr5IwjXFTftgtw/znxKgwvzzLXgt2yyI2TI4BS4nTSvZ+B zlGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wY+SlxifjwFh1fL1Zrf3k32nY+1n0BUqZuDq0YH3BWQ=; b=Iuvovm485XnqGCtntu7Y3wdQznallXNQq1aLDgTxtbIse28/TGGhnoxxGY8rktz6KG 36304Hcoa1aLAQ428NM6OKHDS4GxnihU4mNq8rn6cg6szG9W/p190wbWT+yfdT4dZ8VF pI50/U2VV4sZtmwnY5RTBIdmRcmhcKDDQmlhZI10V1hZeOJYFPWm64Q5+1O1up6wa1Vg RFZgvbtmjfm1qnMkaEcRzC8jYRMikKzrOoAVlha2KMIoGPupRdoWBBvq/g1XrFnk+I2Q ewko1F2DOSoP/txhHJhWyVvupLu3ZElWpOdTicgV3zybNkPGlA53vLDq+qIFccBKL6dm NiLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UtWrcLHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g71si15138949pgc.419.2018.12.04.03.14.07; Tue, 04 Dec 2018 03:14:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UtWrcLHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbeLDLHh (ORCPT + 99 others); Tue, 4 Dec 2018 06:07:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:56648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728468AbeLDLHd (ORCPT ); Tue, 4 Dec 2018 06:07:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6ED62146D; Tue, 4 Dec 2018 11:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543921652; bh=ERouDznQErs35qlnu0TlxEJYjniRQBwiErizyrcgqA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UtWrcLHL1NA3HFyM5or8tAK3q3lHtj5kHl0Z3WytA/fDKq60BkMZBjcq6GZgrpdnF KkNwiDvzH4RtAFxhsCUZnzBK+UeZFroyfdNCCbvBa3ddR3N6r9DYmsx85yFfMLaQF0 NJvFuM6AaE/MW9uP5+h9YN3MGlMBvComijJVyivg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-wireless@vger.kernel.org, youling257 , Larry Finger Subject: [PATCH 4.14 137/146] staging: rtl8723bs: Add missing return for cfg80211_rtw_get_station Date: Tue, 4 Dec 2018 11:50:23 +0100 Message-Id: <20181204103732.340898051@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181204103726.750894136@linuxfoundation.org> References: <20181204103726.750894136@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Larry Finger commit 8561fb31a1f9594e2807681f5c0721894e367f19 upstream. With Androidx86 8.1, wificond returns "failed to get nl80211_sta_info_tx_failed" and wificondControl returns "Invalid signal poll result from wificond". The fix is to OR sinfo->filled with BIT_ULL(NL80211_STA_INFO_TX_FAILED). This missing bit is apparently not needed with NetworkManager, but it does no harm in that case. Reported-and-Tested-by: youling257 Cc: linux-wireless@vger.kernel.org Cc: youling257 Signed-off-by: Larry Finger Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1293,7 +1293,7 @@ static int cfg80211_rtw_get_station(stru sinfo->filled |= BIT(NL80211_STA_INFO_TX_PACKETS); sinfo->tx_packets = psta->sta_stats.tx_pkts; - + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_FAILED); } /* for Ad-Hoc/AP mode */