Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8114287imu; Tue, 4 Dec 2018 03:14:45 -0800 (PST) X-Google-Smtp-Source: AFSGD/XOGfd5Ml7cETDFGwglnGvc52XoyhmwCN/udhCbgELbdnop4zSDKlU4WHRKdxk/c7hca4Lm X-Received: by 2002:a63:8149:: with SMTP id t70mr16820960pgd.172.1543922085551; Tue, 04 Dec 2018 03:14:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543922085; cv=none; d=google.com; s=arc-20160816; b=iBHfRiXkj4ILU6+VOpzrks2pWAOV5Wz8a4ExI9JnqQhV4+FaaYDsMGeK3GHekVBq7J bP6F+/zs+mg8GLH+9tFIJo+xj2NHxso3P1RqfrPBOnH97HRJrkhHxXG++JtFDf9jYYcA aTgDz9zogrRgTjZtnlhYtq/AixLd2NGul7qqevYul9gdcSSmhF2DvLcaTtGTPHhZpZFg RWkAZgDQXFYY4Ng4V3hwxEm1bn8wnhf5tpxpl4CAW/69XmLtEymnPnFMKez2lczv8Qmd qXMMUszLhBAkvWwEOyYyAXhyjjAhRw47Jvf+HPwMBEErt2EW4V79jvZFFj4Bxc4gFCFs KGKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6cN8QZ0NCMNNAMd8zxE1pzMTujLqzqazs9Nkyjoi500=; b=RvM4ZhdHmxS9hgyPIrHmmy8miwgmE0NDu2XPk7l+Cq0Rqqy56Pdyp3feIRkaJa7Inb LbLUBOIGop+owBSurCrHtcQ07vyiZhjgcewRFtKxfhPOi0iqZtX5AGfNSw/J729DGLtn Aw9dciRpmmMjqRuwCbRTeAMXaVMz2FZEFld+SzAe5xykmvTXFkEMnW/KYSXtwo/io98o idCq6Y0Wa9XkBkmvzTPwecrkE5Oj0VDwjLhj6neArZtr6Kf7pkOJLzDRbegFbFj3pRb9 Z/Ecstea6C2441bG3DUNmRQanumCLrPwY0b3oh1cNdyweeVGhOWUtCCZlSK31sqKzpEw +lkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dj3AQGC2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si15086968pgc.41.2018.12.04.03.14.30; Tue, 04 Dec 2018 03:14:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dj3AQGC2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbeLDLHX (ORCPT + 99 others); Tue, 4 Dec 2018 06:07:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:56378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728435AbeLDLHU (ORCPT ); Tue, 4 Dec 2018 06:07:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 54D112082D; Tue, 4 Dec 2018 11:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543921639; bh=w8GLwSqz3zNnJ+UnTOlniQslIjpb/tNSrLiDeBLmdPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dj3AQGC28HtPMrWxjHmSNAdb+1UzMOTyHFS8w8ig7RFMzr0plWHkp9WvzhB3LUjQ4 pIIi5nK6hevIEo3ENWtnujIng2w0QPosvyWNoukjkzAB0yekEXXMLMky+zmvYplJYT 30dX7BM8BsbwzAYu5Pvq6xEQ7QSkQ0ZBwHLpanxc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luis Chamberlain , Randy Dunlap , Andrew Morton , Linus Torvalds Subject: [PATCH 4.14 142/146] lib/test_kmod.c: fix rmmod double free Date: Tue, 4 Dec 2018 11:50:28 +0100 Message-Id: <20181204103732.536311320@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181204103726.750894136@linuxfoundation.org> References: <20181204103726.750894136@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luis Chamberlain commit 5618cf031fecda63847cafd1091e7b8bd626cdb1 upstream. We free the misc device string twice on rmmod; fix this. Without this we cannot remove the module without crashing. Link: http://lkml.kernel.org/r/20181124050500.5257-1-mcgrof@kernel.org Signed-off-by: Luis Chamberlain Reported-by: Randy Dunlap Reviewed-by: Andrew Morton Cc: [4.12+] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- lib/test_kmod.c | 1 - 1 file changed, 1 deletion(-) --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -1221,7 +1221,6 @@ void unregister_test_dev_kmod(struct kmo dev_info(test_dev->dev, "removing interface\n"); misc_deregister(&test_dev->misc_dev); - kfree(&test_dev->misc_dev.name); mutex_unlock(&test_dev->config_mutex); mutex_unlock(&test_dev->trigger_mutex);