Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8122788imu; Tue, 4 Dec 2018 03:23:45 -0800 (PST) X-Google-Smtp-Source: AFSGD/UXsqRaAgnBL/BmVQcW4Csox72updPmBCz4KY8Z8oUoCHPmEPhCru9a9id2nRMndt3IOJMr X-Received: by 2002:a65:5a8e:: with SMTP id c14mr16262114pgt.137.1543922625373; Tue, 04 Dec 2018 03:23:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543922625; cv=none; d=google.com; s=arc-20160816; b=fICEDYfggdJCLsDeQOzhgA3Cwpa5U7x+/yFWX+n2d0NX/5WQ2He6nWoRKi8CA/QO4p lK222lCtrJ5+Zm3HRqacHcgvAyInBlKIGkBricNaOIL3/Jc6GZOv0GOhzyArXhPrTRAW af+bnRg1IWNbK7vb5RDk4Z717X1HDE8I3yx9o2M6ixJoQ3iZie37i6l4+eNB4ryV6Fh2 mmHvDoTd9hDvuL+punuBXakQEsKY+NP9qdoVFquMZjRaR/cplBqwAfTfd3YaKLKiKfKa 9ThPDuCd1FskLnODtSeC3veOx6F8cmJDGFgGjJudMJ9GUBhxbpg3+GI4pgGvYMrmgzUv tJaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/NPjMSZDAW9xORucXSAV2OV1EBqBU4297k/sTVH6YHg=; b=hrEX3CIQcGMNo63kdwyYbEhOuuCGxt3cDKZXL1DrNLOGx2tZT4AIJ5Hgy3aBlcFG7n chFTgEU3iUi1/h4k3Wtjdf9ChTJhmvXKiaEraUbvbj0YRTF42QgzB3Kr2Sr+IVOQSmN3 e6F4HxS2Kx8j50Iat4gfgWbr8UsCYbI0e4QfUAiGyPxx8ydKqgNwSK5CVy5GvF5TWASY VyZlpSnGH5JdolcnJxMzhkF6S8fgThdmte2bNRx1b0E3fOQga5HKXApDRRLStCiiLF3o tAMX0KhEbVdU8i9ZfVNxBUzjFe7PJhuSgk/1DdVhtRampPG2yOzYN0G8hH0wLtAmFuvt Ftrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wOtS4LyJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x74si18110724pfe.23.2018.12.04.03.23.30; Tue, 04 Dec 2018 03:23:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wOtS4LyJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbeLDLCq (ORCPT + 99 others); Tue, 4 Dec 2018 06:02:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:48872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbeLDLCo (ORCPT ); Tue, 4 Dec 2018 06:02:44 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69DC02146D; Tue, 4 Dec 2018 11:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543921363; bh=nmTklXzd1IAB7WxyavY8WHHLdTMDoUzEqYuyAxQVdeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wOtS4LyJY6Eu0qy9bLWSqK9D/4Ayz1yYYYl/I/YTM0+vieiD8RO5igF0i2S9APREW +3taddjC7GQwIF/veGxeZzm3dWCqYCFcZmL0HmRk9Zj0xqqa61CaCj1NKvTYbHSPwL pK96dk/nWUE8ImyK9WwpzZZb9G/GqQy1VO6agueM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Borisov , Qu Wenruo , Shaokun Zhang , David Sterba , Ben Hutchings , Sasha Levin Subject: [PATCH 4.14 043/146] btrfs: tree-checker: Fix misleading group system information Date: Tue, 4 Dec 2018 11:48:49 +0100 Message-Id: <20181204103728.593587894@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181204103726.750894136@linuxfoundation.org> References: <20181204103726.750894136@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ commit 761333f2f50ccc887aa9957ae829300262c0d15b upstream. block_group_err shows the group system as a decimal value with a '0x' prefix, which is somewhat misleading. Fix it to print hexadecimal, as was intended. Fixes: fce466eab7ac6 ("btrfs: tree-checker: Verify block_group_item") Reviewed-by: Nikolay Borisov Reviewed-by: Qu Wenruo Signed-off-by: Shaokun Zhang Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin --- fs/btrfs/tree-checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index fa8f64119e6f..f206aec1525d 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c @@ -399,7 +399,7 @@ static int check_block_group_item(struct btrfs_fs_info *fs_info, type != (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA)) { block_group_err(fs_info, leaf, slot, -"invalid type, have 0x%llx (%lu bits set) expect either 0x%llx, 0x%llx, 0x%llu or 0x%llx", +"invalid type, have 0x%llx (%lu bits set) expect either 0x%llx, 0x%llx, 0x%llx or 0x%llx", type, hweight64(type), BTRFS_BLOCK_GROUP_DATA, BTRFS_BLOCK_GROUP_METADATA, BTRFS_BLOCK_GROUP_SYSTEM, -- 2.17.1