Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8127094imu; Tue, 4 Dec 2018 03:28:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/XVQt7Wei2KbLgXOHc2bHcGnsmjzmdEkqZdI/ycql6PNfcxffL0omNib0dbhdVNjCYZCssb X-Received: by 2002:a62:4641:: with SMTP id t62mr19479983pfa.141.1543922916005; Tue, 04 Dec 2018 03:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543922915; cv=none; d=google.com; s=arc-20160816; b=QxnG4aGWEpe4o8Q8EtIe1ra9P5evpaUkUq6711lFsUWtyMvPjD+FnCOHQZTe3L9IdS JtQmAqIAc1WjV52T/f9kMq4kK2K+4tD5fFiaPEunHiG9vsw4Xf4rz5l0J2jB1F1lNfkP lsURg80ZeSFDSzAnwBqt+OwSfecGwj1lhILo+H5YgOI8+MLJRERuzHER6Sq13h3oWzyr WWDrlZYKE7qbUzPb61B1lywgiu7n7zQut5PQOIffHqVzs4vYgQcUVyJkS9afwTUh3OKy 4bCnIC4NeY5IQwu9fb7bqtNv0d8CFJpwHW8J9a5ywM3M+4pTxhJWoXIY6eGxCfqmxWT4 apjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dywNk1vDCmBOKed8JsSQPLHdWV2cUelzlxpl7MW0Nak=; b=woDSi7JVmxmSy28Bh4IsqO+zIJPx9x9aBCIOywM4sdcmtqosvlrp+d3Wn2+dYzCM6H LxL0lvsHh7CnF9uwgB/LoetW5QFE9q7ovvraq5Q/+j3p/sd+Xprpmq88CbiKu5CPCecd w1mgBbnLd3YJJ3G2x0WipqbKW6NsrFqn/r5ovGH3oefpeAbe8Jurx+2tYq4/CSm6jZpk rUWWDD3wKdw+0jvvSG4prA+bKxeY/e/r6jlH8QVljtIuC0f/NqIsg9UakoSpOfhKAgwR GDjkfsPc7lzxqipybt7dJEKV21JXg5OpUsB6yUuC8jBrfqfPf6VqXcp1YWLzjUGCwW/3 DgnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CG8k2TsK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d39si12494106pla.278.2018.12.04.03.28.20; Tue, 04 Dec 2018 03:28:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CG8k2TsK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbeLDL0d (ORCPT + 99 others); Tue, 4 Dec 2018 06:26:33 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:33286 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726745AbeLDL03 (ORCPT ); Tue, 4 Dec 2018 06:26:29 -0500 Received: by mail-qt1-f196.google.com with SMTP id l11so17575606qtp.0 for ; Tue, 04 Dec 2018 03:26:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dywNk1vDCmBOKed8JsSQPLHdWV2cUelzlxpl7MW0Nak=; b=CG8k2TsKJsqHMedzobNW/WfVlCE+rjQx+8Oyp142ZhF160lDI0J6qTHHAI1QUQlfNH 1k9us2FUeK9U/+ssVE7PzU5K2u2QJbTcQJRggUf43sx3W0f7UP0kL02bSleIz8pKq0tC 8dCJdooCJuta9SbDjwHI5TSScdGmBnO4DtLi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dywNk1vDCmBOKed8JsSQPLHdWV2cUelzlxpl7MW0Nak=; b=Wqzi4tLs6lZp5sJm4rxJ5laWhijYilpvCj7mdS6HYqd5Krwcri5qoY6zhPQ+EXkCKj +Dh4j8iuMXbx33Gv2aHQvn8kdQnGw20+8RCLOqwYZVGW0/l1wrj8Dvl5ep4AYfNuEeIn v+DAnxV0f8KKILDj80m2bbDYd9Gcyp9VdaUxho5LOkyyPGGpWEE/Xs4boVXOfPSDmaYt mcaNXvQaLniKY80tXHbQSxvOt5IvNnE+zrF6OF0tvTe4eRs8s/vXwAa7hyZtrkBvGz76 wkiGYDUIvzYf/fOt8qhtQVwktMTCn54ElNx2AVns49Y4811kQuTPGmc7d9rwscHdOQ7i aB9Q== X-Gm-Message-State: AA+aEWbE9rg5oIv7+gfa31gIQnpNnoTvx+jhgPbbOmUVOeHwdlkT85go YaAhGPT/X0/jpmPnM0tZWJ2psycgrGRhet9KjT5oow== X-Received: by 2002:ac8:203:: with SMTP id k3mr19585235qtg.64.1543922787220; Tue, 04 Dec 2018 03:26:27 -0800 (PST) MIME-Version: 1.0 References: <20181129165709.GF2688@localhost.localdomain> In-Reply-To: <20181129165709.GF2688@localhost.localdomain> From: Amit Kucheria Date: Tue, 4 Dec 2018 16:56:15 +0530 Message-ID: Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: qcs404: Add thermal zones for each sensor To: Eduardo Valentin Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Andy Gross , vkoul@kernel.org, Khasim Syed Mohammed , David Brown , Rob Herring , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 29, 2018 at 10:27 PM Eduardo Valentin wrote: > > On Tue, Nov 27, 2018 at 09:59:07PM +0530, Amit Kucheria wrote: > > qcs404 has 10 sensors connected to the single TSENS IP. Define a thermal > > zone for each of those sensors to expose the temperature of each zone. > > > > Signed-off-by: Amit Kucheria > > Reviewed-by: Vinod Koul > > Tested-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/qcs404.dtsi | 206 +++++++++++++++++++++++++++ > > 1 file changed, 206 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > index 57d14d8f0c90..cbc3fd378893 100644 > > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > @@ -30,6 +30,7 @@ > > reg = <0x100>; > > enable-method = "psci"; > > next-level-cache = <&L2_0>; > > + #cooling-cells= <2>; > > }; > > > > CPU1: cpu@101 { > > @@ -38,6 +39,7 @@ > > reg = <0x101>; > > enable-method = "psci"; > > next-level-cache = <&L2_0>; > > + #cooling-cells= <2>; > > }; > > > > CPU2: cpu@102 { > > @@ -46,6 +48,7 @@ > > reg = <0x102>; > > enable-method = "psci"; > > next-level-cache = <&L2_0>; > > + #cooling-cells= <2>; > > }; > > > > CPU3: cpu@103 { > > @@ -54,6 +57,7 @@ > > reg = <0x103>; > > enable-method = "psci"; > > next-level-cache = <&L2_0>; > > + #cooling-cells= <2>; > > }; > > > > L2_0: l2-cache { > > @@ -507,4 +511,206 @@ > > #interrupt-cells = <2>; > > }; > > }; > > + > > + thermal-zones { > > + aoss-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 0>; > > + > > + trips { > > + aoss_alert: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > > A passive trip and yet no cooling map associate to it.. Oops, was waiting for cpufreq to be enabled on the platform. I'll get rid of the trips for now. > > > + }; > > + aoss_crit: trip1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + dsp-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 1>; > > + > > + trips { > > + dsp_alert: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + dsp_crit: trip1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + lpass-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 2>; > > + > > + trips { > > + lpass_alert: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + lpass_crit: trip1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + wlan-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 3>; > > + > > + trips { > > + wlan_alert: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + wlan_crit: trip1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cluster-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 4>; > > + > > + trips { > > + cluster_alert: cluster_alert { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + cluster_crit: cluster_crit { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu-thermal0 { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 5>; > > + > > + trips { > > + cpu_alert0: cpu_alert0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + cpu_crit0: cpu_crit0 { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu-thermal1 { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 6>; > > + > > + trips { > > + cpu_alert1: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + cpu_crit1: trip1 { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu-thermal2 { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 7>; > > + > > + trips { > > + cpu_alert2: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + cpu_crit2: trip1 { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu-thermal3 { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 8>; > > + > > + trips { > > + cpu_alert3: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + cpu_crit3: trip1 { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + gpu-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens 9>; > > + > > + trips { > > + gpu_alert: trip0 { > > + temperature = <75000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + gpu_crit: trip1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + }; > > }; > > -- > > 2.17.1 > >