Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8131039imu; Tue, 4 Dec 2018 03:32:45 -0800 (PST) X-Google-Smtp-Source: AFSGD/WfuhcDDSfTapbAmIfKhJrt9NGft+BEFl4QMrLtE/ouw33bqS/eu5fpvXupVOqeJJ/E8QdY X-Received: by 2002:a63:1204:: with SMTP id h4mr16504771pgl.51.1543923165731; Tue, 04 Dec 2018 03:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543923165; cv=none; d=google.com; s=arc-20160816; b=mC+iEcwUtxkcLxbbOYKkDpkWenjY1CgCtGxEpqsxm3kz533uwZNeLDFrrXiooBJBie 9Hv1Wc9FZBUjQaxQzDhuSfOfrjaEvxfAx9kyFun3XjZ+k+7/hrZz95aZ5GseAIugYGdE oV5+K+2A1SNDHDUcA/7q8/KNg0uuncgqc0nwetI03NNdPvr5Pe1BfZuuh3aL01H2yRVu Spe2Up3RckrbR3h3GypO8WChmbrfFwMGkkhcQbHYBg3ENOLQ+03H3cPmPa+VjINsfM2+ /vffWxH9+dVSrhdgJM3sKG2ctFBvWcVjBJvLZt22+pXW2czVltDcWgbNtq8BNtNHgQc/ UIxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=2+IPzr31w0id4mq+HkzhcuikzVsMzXfYOT4elQgXOhc=; b=E+lSQvZmDXMuCwQZB9xZ9HqF20i6bKXK0OZuwX4VlRoONxk7qQqggKzGWwbIacpdez 07WeDLUntLkp9D5Cm+EkEpH93EC3weYNT1brS2my/8kNbfqsnAitkRYR+1ptX+D1UXm6 HNw9aXSBlm4XgpWlzbJ6118fByPHNmUUpZxu5T6akGSzbsWVrpWFo5jRzy8DZJoqbxUN FUp1dm4QAnJympEfxfBjcTHCAh6ukBV+eM8zIeefgliDJgpRwktXTYS1i+/9wXXp+xAg T+4dH/xfCPtS3dg6ggjjEQpLcqQlzZFvde1QG2QBzdZjbYqyjw4YAYskJ+P9+LrrcaPf NIEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u1ACJAUp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g71si15138949pgc.419.2018.12.04.03.32.29; Tue, 04 Dec 2018 03:32:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u1ACJAUp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbeLDLbx (ORCPT + 99 others); Tue, 4 Dec 2018 06:31:53 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46104 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbeLDK4S (ORCPT ); Tue, 4 Dec 2018 05:56:18 -0500 Received: by mail-pf1-f193.google.com with SMTP id c73so8013154pfe.13; Tue, 04 Dec 2018 02:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2+IPzr31w0id4mq+HkzhcuikzVsMzXfYOT4elQgXOhc=; b=u1ACJAUp5fjHnM8ICWJTyxgCIeybsnCQfPIpNlP33msmtyEO0Jw7CxnKcUpF8KjbDj u6pMz1Sw5TVKI34mMRO+Ng/uMzPs7nnvjKCiy1NPWDNqgkWmkTbt1PMSD+IC1Imi3/+F oF6E3nvmGVgzjRNQtTy5l0TTizwEmVyl498D5rlB2F6tF3STkANcsfjRiVkauMwiq0cS ma//wKlRAY6+id2ybC7o4n9PNS5SX+LaIpgS82BNmroiACtukR9zmNpc5e0p92aRMY0L HeOHvp+OzOpIuR1B6VlPgSQovsrOu+pUybYdMp87tNviPcbI+ZcHRK+PO5lhYuXsJmBS Dz1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2+IPzr31w0id4mq+HkzhcuikzVsMzXfYOT4elQgXOhc=; b=q0Jj/mdnGdMNCt6ZVcIXjeozTmGxdYkYYtAXR42PkGJ1ReMg8f/ViHfVScYLdLFgq1 Gc00hgJX+yffuobyOA2ZQ3qBEBbQ3Y202tGlnLl9boJGaiF/83sgeISgeCSEbiCPLgrQ fH2RbTxez0D20x6AyEbbyTeTs0eJAYWEtPKmORhA8CJa6XRoSQkf5TwUwAtpaBWLhNrJ 7yJeuUDE3LR4Tt+eOjbmHmRaBnXf8mbAOiGyYDHXRWJj+JEfQr0eGrAjHP+16LIFq6mY HcUqxyF6oO9EjVh0o5t5jMsUHai/o9pF1+hRezbAe2o2BK2RSIJnYGxZDncib2mg5N3K wnEw== X-Gm-Message-State: AA+aEWYxHW/u6sWpfT+b5H91u6h9Ci05BE9rhOOvF1/ED5UjiFKwHFmQ t83KwSEk+ho5xt6qILBPt5k= X-Received: by 2002:a63:e19:: with SMTP id d25mr16230433pgl.272.1543920977093; Tue, 04 Dec 2018 02:56:17 -0800 (PST) Received: from [10.231.245.170] ([125.29.25.186]) by smtp.gmail.com with ESMTPSA id y184sm20206691pgd.71.2018.12.04.02.56.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 02:56:16 -0800 (PST) Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit To: Brendan Higgins , gregkh@linuxfoundation.org, keescook@google.com, mcgrof@kernel.org, shuah@kernel.org Cc: joel@jms.id.au, mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, julia.lawall@lip6.fr, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, robh@kernel.org, dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com, knut.omang@oracle.com References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> From: Frank Rowand Message-ID: <630d0c82-401e-28f8-73fc-6e684ec57bbf@gmail.com> Date: Tue, 4 Dec 2018 02:56:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181128193636.254378-18-brendanhiggins@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/18 11:36 AM, Brendan Higgins wrote: > Migrate tests without any cleanup, or modifying test logic in anyway to > run under KUnit using the KUnit expectation and assertion API. > > Signed-off-by: Brendan Higgins > --- > drivers/of/Kconfig | 1 + > drivers/of/unittest.c | 1405 ++++++++++++++++++++++------------------- > 2 files changed, 752 insertions(+), 654 deletions(-) < snip > I am travelling and will not have an opportunity to properly review this patch, patch 18, or patch 19 until next week. -Frank