Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 4 Dec 2018 13:13:23 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Sam Bobroff <sbobroff@linux.ibm.com>
Cc:     daniel@ffwll.ch, airlied@redhat.com, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm/ast: Fix connector leak during driver unload
Message-ID: <20181204121323.GC21184@phenom.ffwll.local>
Mail-Followup-To: Sam Bobroff <sbobroff@linux.ibm.com>, airlied@redhat.com,
        airlied@linux.ie, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <cover.1543798395.git.sbobroff@linux.ibm.com>
 <1e613f3c630c7bbc72e04a44b178259b9164d2f6.1543798395.git.sbobroff@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1e613f3c630c7bbc72e04a44b178259b9164d2f6.1543798395.git.sbobroff@linux.ibm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 03, 2018 at 11:53:21AM +1100, Sam Bobroff wrote:
> When unloading the ast driver, a warning message is printed by
> drm_mode_config_cleanup() because a reference is still held to one of
> the drm_connector structs.
> 
> Correct this by calling drm_crtc_force_disable_all() in
> ast_fbdev_destroy().
> 
> Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
> ---
> v2 * Changed to use drm_crtc_force_disable_all().

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
>  drivers/gpu/drm/ast/ast_fb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 0cd827e11fa2..de26df0c6044 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -263,6 +263,7 @@ static void ast_fbdev_destroy(struct drm_device *dev,
>  {
>  	struct ast_framebuffer *afb = &afbdev->afb;
>  
> +	drm_crtc_force_disable_all(dev);
>  	drm_fb_helper_unregister_fbi(&afbdev->helper);
>  
>  	if (afb->obj) {
> -- 
> 2.19.0.2.gcad72f5712
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch