Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8456118imu; Tue, 4 Dec 2018 08:38:16 -0800 (PST) X-Google-Smtp-Source: AFSGD/XkvzCzwZvkPm/9tGe85OQX72PfJOgKT9sjC0OLItfGcgxFEKzvS4g2qcp90IfSBozQyg73 X-Received: by 2002:a63:a452:: with SMTP id c18mr17610038pgp.204.1543941495989; Tue, 04 Dec 2018 08:38:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543941495; cv=none; d=google.com; s=arc-20160816; b=nxr3v30Tq9lLnazkOXCbtmFTk4zRf2qeKoGKY7/Q4CXb5Hodh7DHTfTmnwpA0afi63 c5vT/l5EdhXR1tfBtoTd8KeaWAmex0sIKSlPEWO1SaD/46GGN2U73aryAQPaV0Jtejdc wIvV1Fu7Wi57s1jQVvwug8ehVNnSk+0dVIzRcNoAwnrF85EOoic0oJuPUbKp6/OUCCIR tkUSCcdNpav4BGqX9NJ5BuaCdVIeJnabnCoyHmB0G/xwP4wamxppe26B503Ogfj9W99O s00vi5ZSuIYMRseN+/iRqi9/J1jZ8d0w0MeDXh2kIT4XfH88Y8zED7RUyj5Q9to0X6JP g56g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4JtLpX5MoLOBCXYSQ76Mgss2oVSTtL6KxQT04j18GUs=; b=Fvv/6o4xycyGyj4yVSDerWLvN1aut3lSuFNhEOKM96NEi4NsdmBCseCF1snJ6qFHsu EW4zTug2RW308P8O3Cz7LPdki0i6UnV4fKLIXphbyRDeEgk5jJ5W7U5niG3KAqBiDAs5 oQ7DSYHJEBikAJMqIAyce++mS535l17ck5Ep3dN7qtyVhcHEGH9hvTTBQq8LtYiNKjSb O+shShoI8xcfRtKvBZcYD/wWTHkkiQtzRCct245LMhSpvpTi0I8sT0m807r36ECQ8F/+ Z07oZE2QR0xfRdfyt2VJYH8ym3dDCndAjZpniaD95laM2hq9PRLe7k0syERYoA136fTN y8Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mYmdXCit; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si15526461pgq.207.2018.12.04.08.37.57; Tue, 04 Dec 2018 08:38:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mYmdXCit; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbeLDQgj (ORCPT + 99 others); Tue, 4 Dec 2018 11:36:39 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46982 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbeLDQgi (ORCPT ); Tue, 4 Dec 2018 11:36:38 -0500 Received: by mail-pf1-f195.google.com with SMTP id c73so8463699pfe.13; Tue, 04 Dec 2018 08:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4JtLpX5MoLOBCXYSQ76Mgss2oVSTtL6KxQT04j18GUs=; b=mYmdXCitOyJUoERAkUmgBSFB5skglAfkrBLqnon0R66qPkh9P65wQIcH8tTS5hSWDz PU6bZEMwluKNP8RV4L3Sv2RvuOmtWFkuXgqohvZkMfi7/e1PxXR8vRZSIJgfuj/sJTIK KycUO8uDMDlHJfepsZmreC5aof9pIsfoqP2wTcXdsj0UaPQ357aBXuSSoxF6J/2SuTjb S6bRenIV+0gE7qO14X5UBuJ+5NZTYpalWd3e7lVTr2R4IL1xAKbVVtotiu2cpSlJv4UP vB9MjRIJKgnpXDCN+f2NO9pEHVecyS0IGo6GJfl+JgK9zaF6j0GqiWBZBV6kkNIfQaic 0OcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4JtLpX5MoLOBCXYSQ76Mgss2oVSTtL6KxQT04j18GUs=; b=IE+penfib8wYptpaQQd+cEYVSd7IP1Kpy5tkuekS4wMqWnqkJgTaqyxc0p2C+rAhoN epsfA6i605lVd0hLYF19pMMm396IJ/ltybCIX+tlRlWWPmfJUwAOWbFEbuwyoOpRJB9L JxrR229IBpLsLfpPaqV1R6/l6orxsNmTj8H7TSj7zw6/q8Di1U6it54fc8y0erKgRgYT Yv2+HwVDnNpXnjjVoRqCkQcawmXhekpgDMHIo9oqWclgI2rkGRpTg4DKWyPq20ne127h FdQc+Rd0e4AHrgB1XPSE413gtsxpPp9D6pwn+HHTvElm4DS00gQfJ7IZcl7dHsCJ8LYV eQRg== X-Gm-Message-State: AA+aEWalYj43oheF6q3FB/0DZs8eZxbKnjpYR0pxht+RGOIvZmxfHC4e DMHW6HdgJ/ss27SchY9GUkw= X-Received: by 2002:a63:6302:: with SMTP id x2mr17143897pgb.183.1543941396514; Tue, 04 Dec 2018 08:36:36 -0800 (PST) Received: from localhost.localdomain ([4.16.3.165]) by smtp.gmail.com with ESMTPSA id b5sm48583275pfc.150.2018.12.04.08.36.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 08:36:35 -0800 (PST) Date: Tue, 4 Dec 2018 08:36:33 -0800 From: Eduardo Valentin To: Amit Kucheria Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Andy Gross , vkoul@kernel.org, Khasim Syed Mohammed , David Brown , Rob Herring , Mark Rutland Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: qcs404: Add thermal zones for each sensor Message-ID: <20181204163631.GA1790@localhost.localdomain> References: <20181129165709.GF2688@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 04:56:15PM +0530, Amit Kucheria wrote: > On Thu, Nov 29, 2018 at 10:27 PM Eduardo Valentin wrote: > > > > On Tue, Nov 27, 2018 at 09:59:07PM +0530, Amit Kucheria wrote: > > > qcs404 has 10 sensors connected to the single TSENS IP. Define a thermal > > > zone for each of those sensors to expose the temperature of each zone. > > > > > > Signed-off-by: Amit Kucheria > > > Reviewed-by: Vinod Koul > > > Tested-by: Vinod Koul > > > --- > > > arch/arm64/boot/dts/qcom/qcs404.dtsi | 206 +++++++++++++++++++++++++++ > > > 1 file changed, 206 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > > index 57d14d8f0c90..cbc3fd378893 100644 > > > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > > @@ -30,6 +30,7 @@ > > > reg = <0x100>; > > > enable-method = "psci"; > > > next-level-cache = <&L2_0>; > > > + #cooling-cells= <2>; > > > }; > > > > > > CPU1: cpu@101 { > > > @@ -38,6 +39,7 @@ > > > reg = <0x101>; > > > enable-method = "psci"; > > > next-level-cache = <&L2_0>; > > > + #cooling-cells= <2>; > > > }; > > > > > > CPU2: cpu@102 { > > > @@ -46,6 +48,7 @@ > > > reg = <0x102>; > > > enable-method = "psci"; > > > next-level-cache = <&L2_0>; > > > + #cooling-cells= <2>; > > > }; > > > > > > CPU3: cpu@103 { > > > @@ -54,6 +57,7 @@ > > > reg = <0x103>; > > > enable-method = "psci"; > > > next-level-cache = <&L2_0>; > > > + #cooling-cells= <2>; > > > }; > > > > > > L2_0: l2-cache { > > > @@ -507,4 +511,206 @@ > > > #interrupt-cells = <2>; > > > }; > > > }; > > > + > > > + thermal-zones { > > > + aoss-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 0>; > > > + > > > + trips { > > > + aoss_alert: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > > > > A passive trip and yet no cooling map associate to it.. > > Oops, was waiting for cpufreq to be enabled on the platform. I'll get > rid of the trips for now. Well, the expectation is to have a fully defined thermal zone. Without trips or cooling maps they are not complete. > > > > > > + }; > > > + aoss_crit: trip1 { > > > + temperature = <95000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + dsp-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 1>; > > > + > > > + trips { > > > + dsp_alert: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + dsp_crit: trip1 { > > > + temperature = <95000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + lpass-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 2>; > > > + > > > + trips { > > > + lpass_alert: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + lpass_crit: trip1 { > > > + temperature = <95000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + wlan-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 3>; > > > + > > > + trips { > > > + wlan_alert: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + wlan_crit: trip1 { > > > + temperature = <95000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + cluster-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 4>; > > > + > > > + trips { > > > + cluster_alert: cluster_alert { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + cluster_crit: cluster_crit { > > > + temperature = <110000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + cpu-thermal0 { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 5>; > > > + > > > + trips { > > > + cpu_alert0: cpu_alert0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + cpu_crit0: cpu_crit0 { > > > + temperature = <110000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + cpu-thermal1 { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 6>; > > > + > > > + trips { > > > + cpu_alert1: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + cpu_crit1: trip1 { > > > + temperature = <110000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + cpu-thermal2 { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 7>; > > > + > > > + trips { > > > + cpu_alert2: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + cpu_crit2: trip1 { > > > + temperature = <110000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + cpu-thermal3 { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 8>; > > > + > > > + trips { > > > + cpu_alert3: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + cpu_crit3: trip1 { > > > + temperature = <110000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + > > > + gpu-thermal { > > > + polling-delay-passive = <250>; > > > + polling-delay = <1000>; > > > + > > > + thermal-sensors = <&tsens 9>; > > > + > > > + trips { > > > + gpu_alert: trip0 { > > > + temperature = <75000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > + gpu_crit: trip1 { > > > + temperature = <95000>; > > > + hysteresis = <2000>; > > > + type = "critical"; > > > + }; > > > + }; > > > + }; > > > + }; > > > }; > > > -- > > > 2.17.1 > > >