Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] i3c: Rename dw-i3c-master.c into i3c-master-dw.c
From:   vitor <vitor.soares@synopsys.com>
To:     Boris Brezillon <boris.brezillon@bootlin.com>,
        vitor <vitor.soares@synopsys.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20181126084514.23663-1-boris.brezillon@bootlin.com>
 <20181203110739.0959d6c0@bbrezillon>
 <fd4905e9-a5d9-349c-0dce-be59f0100f31@synopsys.com>
Message-ID: <07f663b9-a973-39cf-c1ab-cc5ffb1a6210@synopsys.com>
Date:   Tue, 4 Dec 2018 18:28:12 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <fd4905e9-a5d9-349c-0dce-be59f0100f31@synopsys.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Boris,

On 04/12/18 00:38, vitor wrote:
> Hi Boris,
>
>
> On 03/12/18 10:07, Boris Brezillon wrote:
>> Hi Vitor,
>>
>> On Mon, 26 Nov 2018 09:45:14 +0100
>> Boris Brezillon <boris.brezillon@bootlin.com> wrote:
>>
>>> Follow the naming scheme introduced by the Cadence driver to keep 
>>> things
>>> consistent.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
>>> ---
>>>   drivers/i3c/master/Makefile                             | 2 +-
>>>   drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
>>>   2 files changed, 1 insertion(+), 1 deletion(-)
>>>   rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)
>> Any opinion on this rename. If you disagree with this, then I'd like to
>> know it.
>>
>> Regards,
>>
>> Boris


I don't agree with the master folder name. The name is redundant.


If you want to change my driver name I don't mind.


>>
>>> diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile
>>> index fc53939a0bb1..c5f52733aa10 100644
>>> --- a/drivers/i3c/master/Makefile
>>> +++ b/drivers/i3c/master/Makefile
>>> @@ -1,2 +1,2 @@
>>>   obj-$(CONFIG_CDNS_I3C_MASTER)        += i3c-master-cdns.o
>>> -obj-$(CONFIG_DW_I3C_MASTER)        += dw-i3c-master.o
>>> +obj-$(CONFIG_DW_I3C_MASTER)        += i3c-master-dw.o
>>> diff --git a/drivers/i3c/master/dw-i3c-master.c 
>>> b/drivers/i3c/master/i3c-master-dw.c
>>> similarity index 100%
>>> rename from drivers/i3c/master/dw-i3c-master.c
>>> rename to drivers/i3c/master/i3c-master-dw.c
>
>
> I already reply on initial thread. Please check my answers.
>
>
> Best regards,
>
> Vitor Soares


Best regards,

Vitor Soares