Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8584581imu; Tue, 4 Dec 2018 10:37:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/UXRggvBXRve15g2X4WdtQ3bIll36CZKR9N8PWPo+M/Ix/zJl6Q8rT4S/la7jcrTcyOvNuA X-Received: by 2002:a63:a112:: with SMTP id b18mr17824947pgf.440.1543948674275; Tue, 04 Dec 2018 10:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543948674; cv=none; d=google.com; s=arc-20160816; b=pODjAlY2FSj4f9u7q6dn0CIVJza2CSkQI0LW+xZlikZtBayooVnmm7gHSRAmFFpFXU riymEDLSnNK1Pd4Df4CIyPyzLjAE1zRI8UHjuUttoT+1aybPJmWlY+VegKKpLPp8B9e9 sXG+1ARYHd1TSm4Bu/ZRpn+ccAPUFj9mJwKXq+hhROJps4LQyzFIVMGjNsZ5qPrD3JAi Uqwv1g/AIm9VrCwHD0DtDKYhXww7+pP2p3FGZjC7Yhq5uXMoezKx0k292FtfDeQoLPBn KEocLA6YDX1Ik03yM+SEA3dU2BZwz3Mf9ggqTo27iJ9fMI6lAhhUQWKp2IuI8qZoQgo/ swrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mJQmC45q0sHPUKqFY2eBFa9J9cofiA6jo93q1bYXOEY=; b=WI39J/hVpg07LEJV2ks0EjHWpuGbNzg6svmQVAoKyZDi5IiTqzv6n6iBl3CDIpnr6Y 8uvacWmk5tAyxUGvJ/5ZTr1F2tVgDXlts1KEAXGugNieFGs5ZoihDbOWL3bCLsMif5bp 0vaUO/TG5WCCgWu96Vhc9iWrXDxp92R9RgIjFMdk7CWFVL1c70cv1FMiqoG52RvGtkTg VQf+vgFwLc7DDRbqoO3zi16FWuM0711u0RLbQ8ejzVOVWM3Cp+T00HMtLaD1FGDj4e8p vcUJAOkwemyjeHOtpdO1pnthsITj6GTEgkBFexFG7jiM6hU0rJvv+kTkAV8mRCF9hbYA 8opQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14si16033675pgf.47.2018.12.04.10.37.39; Tue, 04 Dec 2018 10:37:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbeLDSgk (ORCPT + 99 others); Tue, 4 Dec 2018 13:36:40 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:33916 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbeLDSgU (ORCPT ); Tue, 4 Dec 2018 13:36:20 -0500 Received: by mail-yw1-f67.google.com with SMTP id g75so7407940ywb.1; Tue, 04 Dec 2018 10:36:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mJQmC45q0sHPUKqFY2eBFa9J9cofiA6jo93q1bYXOEY=; b=p4wskd8r2gbeM5Vb45XWNFcTrDuYamrkk5zKmLAULa1aseM9m7rdLWhKcB4agjbRnP 3i4xm3d//eqJxq9uVtiGO8cNzk9y6evQX/J1K4DmH7OM6yOa+x5LjeSfBFFvTRAGS6lK 7I2yQb/7MzfbpJJZhXB8AAcCc+pEPa0dMQkQ1pzrHk06IBOQ6va2zJPObJRN2VfUPwgi 2CLGhXRmVvFLtfiAheMZuXnn+OS5mIP9evBJcPBImyxrHZFx718KaSyT1SAMb4QpVKIn dTkszcuVWoXcBW8JoD9QUspuAFwJ3cqIgqODC4WfQ5eUyvz7oPmrpGPZHFOUR8HrxaHj DF/g== X-Gm-Message-State: AA+aEWbrxv9wtvjnzFP00Ka0UQA/jXyj2hGWrz/slUFCQe4WE4s7AmLE JbyLaozU3ilvJ9Gx2q22BLVfCQVVqHQ= X-Received: by 2002:a81:c90d:: with SMTP id o13mr22130543ywi.348.1543948579745; Tue, 04 Dec 2018 10:36:19 -0800 (PST) Received: from dennisz-mbp.thefacebook.com ([199.201.65.135]) by smtp.gmail.com with ESMTPSA id x82sm4274798ywb.34.2018.12.04.10.36.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Dec 2018 10:36:18 -0800 (PST) From: Dennis Zhou To: Jens Axboe , Tejun Heo , Johannes Weiner , Josef Bacik Cc: kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dennis Zhou Subject: [PATCH 12/14] blkcg: remove bio_disassociate_task() Date: Tue, 4 Dec 2018 13:35:58 -0500 Message-Id: <20181204183600.99746-13-dennis@kernel.org> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20181204183600.99746-1-dennis@kernel.org> References: <20181204183600.99746-1-dennis@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that a bio only holds a blkg reference, so clean up is simply putting back that reference. Remove bio_disassociate_task() as it just calls bio_disassociate_blkg() and call the latter directly. Signed-off-by: Dennis Zhou Acked-by: Tejun Heo --- block/bio.c | 11 +---------- include/linux/bio.h | 2 -- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/block/bio.c b/block/bio.c index ce1e512dca5a..7ec5316e6ecc 100644 --- a/block/bio.c +++ b/block/bio.c @@ -244,7 +244,7 @@ struct bio_vec *bvec_alloc(gfp_t gfp_mask, int nr, unsigned long *idx, void bio_uninit(struct bio *bio) { - bio_disassociate_task(bio); + bio_disassociate_blkg(bio); } EXPORT_SYMBOL(bio_uninit); @@ -2073,15 +2073,6 @@ void bio_associate_blkg(struct bio *bio) } EXPORT_SYMBOL_GPL(bio_associate_blkg); -/** - * bio_disassociate_task - undo bio_associate_current() - * @bio: target bio - */ -void bio_disassociate_task(struct bio *bio) -{ - bio_disassociate_blkg(bio); -} - /** * bio_clone_blkg_association - clone blkg association from src to dst bio * @dst: destination bio diff --git a/include/linux/bio.h b/include/linux/bio.h index 84e1c4dc703a..7380b094dcca 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -516,7 +516,6 @@ void bio_disassociate_blkg(struct bio *bio); void bio_associate_blkg(struct bio *bio); void bio_associate_blkg_from_css(struct bio *bio, struct cgroup_subsys_state *css); -void bio_disassociate_task(struct bio *bio); void bio_clone_blkg_association(struct bio *dst, struct bio *src); #else /* CONFIG_BLK_CGROUP */ static inline void bio_disassociate_blkg(struct bio *bio) { } @@ -524,7 +523,6 @@ static inline void bio_associate_blkg(struct bio *bio) { } static inline void bio_associate_blkg_from_css(struct bio *bio, struct cgroup_subsys_state *css) { } -static inline void bio_disassociate_task(struct bio *bio) { } static inline void bio_clone_blkg_association(struct bio *dst, struct bio *src) { } #endif /* CONFIG_BLK_CGROUP */ -- 2.17.1