Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 4 Dec 2018 14:21:42 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Anders Roxell <anders.roxell@linaro.org>
Cc:     mingo@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com,
        keescook@chromium.org, arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tracing: add cond_resched to ftrace_replace_code()
Message-ID: <20181204142142.4e2e2169@vmware.local.home>
In-Reply-To: <20181204141908.76e7afa5@vmware.local.home>
References: <20181204191229.6851-1-anders.roxell@linaro.org>
        <20181204141908.76e7afa5@vmware.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 4 Dec 2018 14:19:08 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable)
> >  			/* Stop processing */
> >  			return;
> >  		}
> > +		/*
> > +		 * Some archs calls this function with interrupts or preemption
> > +		 * disabled. Howeve, other archs don't and this can cause a

typo "However". But could you write it this way:

	"However, for other archs that can preempt, this can cause an
	tremendous unneeded latency."

Thanks!

-- Steve

> > +		 * tremendous unneeded latency.
> > +		 */  
> 
> Actually, could you move the comment up where schedulable gets set?
> 
> Thanks!
> 
> -- Steve
> 
> > +		if (schedulable)
> > +			cond_resched();
> >  	} while_for_each_ftrace_rec();
> >  }
> >    
>