Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8652638imu; Tue, 4 Dec 2018 11:51:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/XEkoqjuA0hzIAq4M57oDBkTVstdmoLgbknGlu/3IOp7pKv2FV+PkMIROzFNiKaRqgfCX5A X-Received: by 2002:aa7:810c:: with SMTP id b12mr21190441pfi.44.1543953097481; Tue, 04 Dec 2018 11:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543953097; cv=none; d=google.com; s=arc-20160816; b=nMW+cbaajXOSacn4NvI4NXvu4YfJPTD/p7Br/k1D4zetlR3xOaSA6WBJcOuMYJktRW El/9kwPeaBVeI56Way3Jwu+4Asf7ZfT8y5BXtdB+NHY5NZ+FR/hhxRFV7MkQ81m45r+8 GEFJJ0W8oohWwahnV6t5vvRDAq7eyHK6/LlG4uR8ApCTV8Sm299g9ERUDBOMcV9oYKAI 0Lcco0VKRSp3TEvNZcznGTMLOHKe/RRf8U1aCofVpC7M1vYRUwxHl6jtv50O0I484ayv HVoHxe1VE8kME8MhYQ4JNAwREMTpfRlNzFi5cnR2yQfjJHZrfXhefiP4sgO83paz6ySK DmxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Q+ueYi+brXN7pPHAwUWTDfeiGp090xsVy/6F9O9E86E=; b=q3nsc7vGByUxPLvo53IvFv0UPKqIJWpgdxuzL4OssMn9wWrTQHzfef+prDxJ8Jt8w+ 2bxn4I4e93atNqYZgOIP6hWohLIKHpomfJNvtNnhNE+2mSfivg5Wi97McHNPH+H4fk9I FIU/CAI/hF2q+F0UAezBm+wJZZseUPs2d6v6FrC/ok9W2ZL7dzcSf24fLB9+QoYerTSv 7KKDJu9nbAgDxWRENmJieTBcNjWvMn0Tx7hWJXWTjpUVrB1H1vAgRTa8TvpX7Ily1yi7 LelMI6sW44juIgbZiqpOIYXAZVzqCXTK1cRhpZM29mSNyZ4b10OFku7dNAWi9P3lggT6 bvyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=rdLIjCGj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17si21369131pfc.198.2018.12.04.11.51.22; Tue, 04 Dec 2018 11:51:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=rdLIjCGj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbeLDTuG (ORCPT + 99 others); Tue, 4 Dec 2018 14:50:06 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:37752 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbeLDTuE (ORCPT ); Tue, 4 Dec 2018 14:50:04 -0500 Received: by mail-yb1-f193.google.com with SMTP id w129-v6so5801276ybe.4 for ; Tue, 04 Dec 2018 11:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q+ueYi+brXN7pPHAwUWTDfeiGp090xsVy/6F9O9E86E=; b=rdLIjCGjf0tAo/Mp4Kny0fqVkOhTxceoBFcGu715eAhPc4QSjcfOFbregjVvWysA4g OFhq2Kv5A3/fmL4WiVdxFam0H7sVbVUAjSBO1+VMItULxS2Oktve08quU8YU/EihF51c 5vgqcqxmcxz6IFcwYbXNsHU+wm7gE3eRAmq2SFrSGkMb8WuaCebEB2U8Zcbr8mnCEwUE EEOWpScyOeFpUwmblq6k0XKhLKQmbCex2t6S12OZmI+69rF6s9BJZWsN4xJx+EZ7LZ3p N4toDwckwREJGuOA9MC8sbywTn6WDBGdVYqKvK3HRA364Bp4ojsAajuBQTrhM5c8awp8 bZkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q+ueYi+brXN7pPHAwUWTDfeiGp090xsVy/6F9O9E86E=; b=WwZmTomRqj46IbhqEHwS9Z8HTHm7AGa9dg7ckyxyn14jyJMhxsLxRAE9uyR0/fabyQ 539J+//gAB03mKdUAoORMo7RBMlrNYV1APbCJ+Fr4fl4OJZ6HjBKE+AyudOYuIQiINk9 qvOZzke06keUXA4+EJ+ASiIC9lFi2ZuV/oETTGtxO4Cerwb3lVclHZU9jQ+SfrcKaNxx rqciXgLMfnaNaGUUsjD7rk32m+S+5Y7hztvJjxhM5QkwG+7vFPB7boHJTwnXSpD3HznC yFl7/dwJiRV+QlLY0Uz4BMgxX1/aFHVb5eJm/naO5Eh42FMFsegavWhWi/UGYj+VMbGF /fYg== X-Gm-Message-State: AA+aEWbwkpHCyeIsgJDIxK3RebTjgotz4uaOMih406vtY+PcUKs7wmgv ybJfPVlockeJEYeZLYvWpXdcCQ== X-Received: by 2002:a25:a285:: with SMTP id c5mr1650728ybi.356.1543953002922; Tue, 04 Dec 2018 11:50:02 -0800 (PST) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id j12sm2747003ywk.43.2018.12.04.11.50.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 11:50:02 -0800 (PST) Date: Tue, 4 Dec 2018 14:50:01 -0500 From: Josef Bacik To: Dennis Zhou Cc: Jens Axboe , Tejun Heo , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/14] blkcg: consolidate bio_issue_init() to be a part of core Message-ID: <20181204195000.gwhgdqa7ouaf73sp@MacBook-Pro-91.local> References: <20181204183600.99746-1-dennis@kernel.org> <20181204183600.99746-8-dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204183600.99746-8-dennis@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 01:35:53PM -0500, Dennis Zhou wrote: > bio_issue_init among other things initializes the timestamp for an IO. > Rather than have this logic handled by policies, this consolidates it to > be on the init paths (normal, clone, bounce clone). > > Signed-off-by: Dennis Zhou > Acked-by: Tejun Heo > Reviewed-by: Liu Bo > --- Reviewed-by: Josef Bacik Thanks, Josef